Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Byron block generation is feature complete and tested #1194

Closed
mrBliss opened this issue Nov 6, 2019 · 5 comments
Closed

Make sure Byron block generation is feature complete and tested #1194

mrBliss opened this issue Nov 6, 2019 · 5 comments
Assignees
@edsko
Labels
byron ledger integration byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus testing
Milestone
S5 2020-01-30

Comments

@mrBliss
Copy link
Contributor

mrBliss commented Nov 6, 2019

In Ouroboros.Consensus.Ledger.Byron.Forge.forgeBlock, we forge a block that can contain transactions, delegation certificates, update votes and proposals. Since we don't have a Byron transaction generator #888, this code hasn't been properly tested yet, as we only test with empty blocks. This should be done before we let the new node forge new blocks.
@mrBliss mrBliss added consensus issues related to ouroboros-consensus mainnet labels Nov 6, 2019
@mrBliss mrBliss added this to the Consensus_IntegrateByronLedger milestone Nov 6, 2019
@mrBliss mrBliss mentioned this issue Nov 6, 2019
Merged
@mrBliss mrBliss removed the mainnet label Nov 7, 2019
@mrBliss mrBliss mentioned this issue Nov 7, 2019
Closed
@mrBliss mrBliss modified the milestones: Sprint 1.1.0, Sprint 1.2.0 Nov 28, 2019
@mrBliss mrBliss removed this from the S2 2019-12-19 milestone Dec 18, 2019
@mrBliss mrBliss self-assigned this Dec 23, 2019
@mrBliss mrBliss added this to the S3 2020-01-02 milestone Dec 23, 2019
@mrBliss mrBliss modified the milestones: S3 2020-01-02, S4 2020-01-16 Jan 2, 2020
@mrBliss mrBliss added the byron Required for a Byron mainnet: replace the old core nodes with cardano-node label Jan 3, 2020
@edsko edsko mentioned this issue Jan 6, 2020
Open
@mrBliss
Copy link
Contributor Author

mrBliss commented Jan 6, 2020

See more details in #888 (comment)

@mrBliss mrBliss mentioned this issue Jan 6, 2020
Closed
@mrBliss mrBliss modified the milestone: S4 2020-01-16 Jan 6, 2020
@mrBliss mrBliss assigned edsko and unassigned mrBliss Jan 6, 2020
This was referenced Jan 10, 2020
Closed
Closed
@edsko
Copy link
Contributor

edsko commented Jan 15, 2020

WIP PR to run Byron with dual ledgers at #1425 .

@mrBliss mrBliss modified the milestones: S4 2020-01-16, S5 2020-01-30 Jan 17, 2020
@nfrisby nfrisby mentioned this issue Jan 21, 2020
Closed
@edsko
Copy link
Contributor

edsko commented Jan 23, 2020

Testing with delegation and update proposals will depend on IntersectMBO/ouroboros-consensus#727 .

@edsko
Copy link
Contributor

edsko commented Jan 24, 2020

WIP PR to generate Byron transactions at #1503 .

@edsko
Copy link
Contributor

edsko commented Jan 28, 2020

#1503 extends the DualPBFT tests with regular transactions. Opened a separate ticket about adding tests for update proposals in #1514, and a lower priority ticket for merging these two tests in IntersectMBO/ouroboros-consensus#725.

@edsko edsko closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsko edsko

Labels
byron ledger integration byron Required for a Byron mainnet: replace the old core nodes with cardano-node consensus issues related to ouroboros-consensus testing
Projects
None yet
Milestone
S5 2020-01-30
Development

No branches or pull requests
3 participants
@mrBliss @edsko @vhulchenko-iohk