Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1928] make testIds for references in DRep form unique #1946

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[#1928] make testIds for references in DRep form unique #1946

merged 1 commit into from
Sep 5, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Sep 5, 2024

List of changes

  • Fix duplicate testIds for link and identity references in DRep form

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka requested a review from Ryun1 September 5, 2024 09:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

@jdyczka jdyczka requested a review from placek September 5, 2024 11:09
@jdyczka jdyczka merged commit ae0ca1b into develop Sep 5, 2024
9 checks passed
@jdyczka jdyczka deleted the fix/1928-unique-testIds-for-drep-form-references branch September 5, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdyczka @placek @j-dyczka