Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use +RTS -N2 -A16m to improve bulk sync performance #506

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Use +RTS -N2 -A16m to improve bulk sync performance #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cardano-node/cardano-node.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ executable cardano-node
ghc-options: -threaded
-Wall
-rtsopts
"-with-rtsopts=-T -I0"
"-with-rtsopts=-T -I0 -N2 -A16m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this will help. The node is run in various scripts with different RTS flags.
Do we need this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it needs to be run with those flags.
But if it is bypassed in scripts somewhere it doesn't do much good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experiments, having -N2 (or greater) has been very important for performance.

-fno-warn-unticked-promoted-constructors

build-depends: base >=4.12 && <5
Expand Down