Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use +RTS -N2 -A16m to improve bulk sync performance #506

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Jan 29, 2020

No description provided.

@@ -140,7 +140,7 @@ executable cardano-node
ghc-options: -threaded
-Wall
-rtsopts
"-with-rtsopts=-T -I0"
"-with-rtsopts=-T -I0 -N2 -A16m"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this will help. The node is run in various scripts with different RTS flags.
Do we need this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it needs to be run with those flags.
But if it is bypassed in scripts somewhere it doesn't do much good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experiments, having -N2 (or greater) has been very important for performance.

@oneEdoubleD
Copy link
Contributor

This was fast - 1h6m for a complete sync of Staging (170 epochs). Previously it was ~6h30m, and the best I've ever actually seen was ~2h30m.

Built with:
nix-build -A scripts.staging.node

@dcoutts dcoutts marked this pull request as ready for review January 31, 2020 11:09
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dcoutts dcoutts changed the title WIP: Workaround for #488 Use +RTS -N2 -A16m to improve bulk sync performance Jan 31, 2020
@dcoutts
Copy link
Contributor

dcoutts commented Jan 31, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 31, 2020
506: Use +RTS -N2 -A16m to improve bulk sync performance r=dcoutts a=karknu



Co-authored-by: Karl Knutsson <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 31, 2020

@iohk-bors iohk-bors bot merged commit 42777db into master Jan 31, 2020
@iohk-bors iohk-bors bot deleted the karknu/sync_488 branch January 31, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants