-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use +RTS -N2 -A16m to improve bulk sync performance #506
Conversation
@@ -140,7 +140,7 @@ executable cardano-node | |||
ghc-options: -threaded | |||
-Wall | |||
-rtsopts | |||
"-with-rtsopts=-T -I0" | |||
"-with-rtsopts=-T -I0 -N2 -A16m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this will help. The node is run in various scripts with different RTS flags.
Do we need this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it needs to be run with those flags.
But if it is bypassed in scripts somewhere it doesn't do much good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experiments, having -N2
(or greater) has been very important for performance.
This was fast - 1h6m for a complete sync of Staging (170 epochs). Previously it was ~6h30m, and the best I've ever actually seen was ~2h30m. Built with: |
This helps resolve issue #488
5f72b16
to
42777db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bors r+ |
506: Use +RTS -N2 -A16m to improve bulk sync performance r=dcoutts a=karknu Co-authored-by: Karl Knutsson <[email protected]>
Build succeeded |
No description provided.