CAD-379 Update nix/cardano-node-service.nix with tracing arguments
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/tracing-fix-cardano-node-service
branch
from
60b7e23 to
5058945
Compare
Jimbo4350
force-pushed
the
jordan/tracing-fix-cardano-node-service
branch
from
5058945 to
91780d0
Compare
I'm not sure, running the output of The output script on my branch does look correct however. The scripts successfully passing in hydra should confirm that I didn't break anything but I'll need somebody from devops to confirm the logging output is what they want. |
disassembler
previously requested changes
Dec 23, 2019
Jimbo4350
force-pushed
the
jordan/tracing-fix-cardano-node-service
branch
from
91780d0 to
cb00aa9
Compare
Jimbo4350
changed the title
nix/cardano-node-service.nix with tracing argumentsnix/cardano-node-service.nix with tracing arguments
Jimbo4350
changed the title
nix/cardano-node-service.nix with tracing argumentsnix/cardano-node-service.nix with tracing arguments
Jimbo4350
force-pushed
the
jordan/tracing-fix-cardano-node-service
branch
from
cb00aa9 to
95d9fb2
Compare
jbgi
approved these changes
Dec 27, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 27, 2019
444: CAD-379 Update `nix/cardano-node-service.nix` with tracing arguments r=jbgi a=Jimbo4350 Previously not specifying a tracer did not turn it off, it just changed its severity. Currently if you do not specify a tracer, that tracer is turned off. Therefore this is a temporary fix until #443 is implemented. Co-authored-by: Jordan Millar <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously not specifying a tracer did not turn it off, it just changed its severity. Currently if you do not specify a tracer, that tracer is turned off. Therefore this is a temporary fix until #443 is implemented.