Move tracers into config .yaml file

[Jimbo4350]

Tracers should be specified from the config .yaml file as having them on the command line is cumbersome.

[CodiePP]

it probably would make sense to type them like: Maybe Severity. This way we can distinguish whether they are on or off, and what the minimum severity is that will pass the filter on this trace.
what do you think?

[Jimbo4350]

@CodiePP I was thinking of a dictionary structure per tracer in the yaml file like this:

TraceBlockFetchClient:
    On: True
    Severity: Debug
    Verbosity: MaximumVerbosity

Or we can add an additional constructor to Severity (maybe Off for example) and we can simplify the dictionary to:

TraceBlockFetchClient:
    Severity: Off
    Verbosity: MaximumVerbosity

or

TraceBlockFetchClient:
    Severity: Debug
    Verbosity: MaximumVerbosity

Maybe Severity would fit nicely if we had an Off Severity value or something similar. Maybe a name like TracerSwitchedOff to be painfully obvious.

[CodiePP]

I was thinking of a dictionary structure per tracer in the yaml file like this:

TraceBlockFetchClient:
    On: True
    Severity: Debug
    Verbosity: MaximumVerbosity

or enabled: True ? can turn on/off the complete trace
currently, verbosity is a global switch. But, this would give more flexibility if it can be defined per trace.
and "Severity" could be renamed to MinSeverity? it is actually the minimum severity level that passes the filter.
you are right, a structure is much better to describe all these options.

[Jimbo4350]

TraceBlockFetchClient:
    Enabled: True
    MinSeverity: Debug
    Verbosity: MaximumVerbosity

Made the changes you suggested above 👍

I'd like to make verbosity definable per trace unless there is a reason not to.

[CodiePP]

could there also be a global default for MinSeverity? so if it is not indicated for a tracer, then the default will be applied.
same goes for the verbosity, which could even have an implicit default of the global default: NormalVerbosity.

[Jimbo4350]

Yep we could define that via Maybe Severity/ Maybe Verbosity. If you get Nothing (parsing an empty field) then we can apply a default Severity/Verbosity. Is this what you have in mind?