add genesis create-cardano command #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverca22
requested review from
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
cleverca22
force-pushed
the
genesis-create-cardano
branch
5 times, most recently
from
c5bf030
to
7a15823
Compare
newhoggy
reviewed
May 3, 2022
newhoggy
reviewed
May 3, 2022
newhoggy
approved these changes
May 3, 2022
cleverca22
force-pushed
the
genesis-create-cardano
branch
from
7a15823
to
76387a2
Compare
* combines generation of byron and shelley eras genesis * auto generates a config based on a node config template * slot timing and start time parameters override template * generates all keys in byron era and converts to shelley era
cleverca22
force-pushed
the
genesis-create-cardano
branch
from
76387a2
to
7eb2159
Compare
|
bors r+ |
|
Build succeeded: |
Jimbo4350
reviewed
May 5, 2022
| @@ -42,6 +46,7 @@ library | |||
| -- we create wrapper types for the ledger types | |||
| -- in this module | |||
| Cardano.Api.Orphans | |||
| Cardano.Api.SerialiseTextEnvelope | |||
There was a problem hiding this comment.
This should not be exposed @cleverca22. I will be undoing this in a future PR
There was a problem hiding this comment.
how else is this code going to convert keys into json?
| @@ -663,7 +663,9 @@ module Cardano.Api ( | |||
|
|
|||
| chainPointToSlotNo, | |||
| chainPointToHeaderHash, | |||
| makeChainTip | |||
| makeChainTip, | |||
There was a problem hiding this comment.
These should not be exposed here
There was a problem hiding this comment.
yeah, these could be moved until a cardano-cli utils file
| Nothing -> fail msg | ||
| Just a -> pure a | ||
|
|
||
| parseFilePath :: String -> String -> Opt.Parser FilePath |
There was a problem hiding this comment.
All of these do not belong in Cardano.Api. They should live in cadano-cli.
There was a problem hiding this comment.
yeah, these could be moved until a cardano-cli utils file
| @@ -148,6 +171,7 @@ runGenesisCmd (GenesisVerKey vk sk) = runGenesisVerKey vk sk | |||
| runGenesisCmd (GenesisTxIn vk nw mOutFile) = runGenesisTxIn vk nw mOutFile | |||
| runGenesisCmd (GenesisAddr vk nw mOutFile) = runGenesisAddr vk nw mOutFile | |||
| runGenesisCmd (GenesisCreate gd gn un ms am nw) = runGenesisCreate gd gn un ms am nw | |||
| runGenesisCmd (GenesisCreateCardano gd gn un ms am k slotLength sc nw bg sg ag mNodeCfg) = runGenesisCreateCardano gd gn un ms am k slotLength sc nw bg sg ag mNodeCfg | |||
| toCounter = LBS.toStrict . textEnvelopeToJSON Nothing . snd | ||
|
|
||
| generateShelleyNodeSecrets :: [SigningKey GenesisDelegateExtendedKey] -> [VerificationKey GenesisKey] | ||
| -> IO (Map (Hash GenesisKey) |
| -- | ||
|
|
||
| runGenesisCreateCardano :: GenesisDir | ||
| -> Word -- ^ num genesis & delegate keys to make |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #3798