Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit 3832 #3839

Open
Jimbo4350 opened this issue May 5, 2022 · 0 comments
Open

Revisit 3832 #3839

Jimbo4350 opened this issue May 5, 2022 · 0 comments
Assignees

Comments

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented May 5, 2022

#3832 has introduced some technical debt that needs to be addressed. See post merge review for details.

Essentially we now have three genesis creation commands: cardano-cli genesis (create | create-staked | create-cardano) This is two commands too many.

cardano-cli genesis create                                                                                 
Usage: cardano-cli genesis create --genesis-dir DIR
            [--gen-genesis-keys INT]
            [--gen-utxo-keys INT]
            [--start-time UTC-TIME]
            [--supply LOVELACE]
            (--mainnet | --testnet-magic NATURAL)

cardano-cli genesis create-staked                                                                                                                 
Usage: cardano-cli genesis create-staked --genesis-dir DIR
            [--gen-genesis-keys INT]
            [--gen-utxo-keys INT]
            [--gen-pools INT]
            [--gen-stake-delegs INT]
            [--start-time UTC-TIME]
            [--supply LOVELACE]
            [--supply-delegated LOVELACE]
            (--mainnet | --testnet-magic NATURAL)
            [--bulk-pool-cred-files INT]
            [--bulk-pools-per-file INT]
            [--num-stuffed-utxo INT]
            
 cardano-cli genesis create-cardano                                                                                                                 
Usage: cardano-cli genesis create-cardano --genesis-dir DIR
            [--gen-genesis-keys INT]
            [--gen-utxo-keys INT]
            [--start-time UTC-TIME]
            [--supply LOVELACE]
            [--security-param INT]
            [--slot-length INT]
            [--slot-coefficient RATIONAL]
            (--mainnet | --testnet-magic NATURAL)
            --byron-template FILEPATH
            --shelley-template FILEPATH
            --alonzo-template FILEPATH
            [--node-config-template FILEPATH]

These are very similar and should be consolidated under the create command with backwards compatibility for the commands create-cardano and create-staked. This should be one PR.

The next step would be to (as much as possible) consolidate runGenesisCreateCardano, runGenesisCreateStaked and runGenesisCreate into a single function. This should be one PR.

After the above consolidation, we may be able to consolidate the "create" command further and/or make decisions about which parameters should be configurable via the command line vs being set in the configuration files.

@newhoggy newhoggy self-assigned this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants