Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-node should not require genesis file and genesis hash arguments #613

Closed
Jimbo4350 opened this issue Feb 28, 2020 · 2 comments
Closed

cardano-node should not require genesis file and genesis hash arguments #613

Jimbo4350 opened this issue Feb 28, 2020 · 2 comments
Labels
maintenance Non-critical improvement or maintenance tasks. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn
Milestone
S9 2020-03-26

Comments

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Feb 28, 2020 •
edited
Loading

After #611 is completed, the genesis file can be obtained from the config yaml file and therefore the genesis hash can be derived from this.
@Jimbo4350 Jimbo4350 added maintenance Non-critical improvement or maintenance tasks. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn labels Feb 28, 2020
@Jimbo4350 Jimbo4350 added this to the S8 2020-03-12 milestone Feb 28, 2020
@rhyslbw
Copy link
Contributor

rhyslbw commented Mar 11, 2020

#611 is closed. Does #648 now unblock this?

@Jimbo4350
Copy link
Contributor Author

Jimbo4350 commented Mar 11, 2020 •
edited
Loading

It wasn't blocked, however I will wait until the following sprint before starting on this issue.

@Jimbo4350 Jimbo4350 modified the milestones: S8 2020-03-12, S9 2020-03-26 Mar 11, 2020
@Jimbo4350 Jimbo4350 mentioned this issue Mar 16, 2020
Merged
5 tasks
iohk-bors bot added a commit that referenced this issue Mar 18, 2020
@iohk-bors @Jimbo4350
Merge #683
565dead 
683: Remove genesis-hash and genesis-file arguments from cardano-node r=Jimbo4350 a=Jimbo4350

Issue
-----------

- #613 

- This PR **results** in breaking changes to upstream dependencies.

Checklist
---------
- [x] This PR contains all the work required to resolve the linked issue.

- [ ] The work contained has sufficient documentation to describe what it does and how to do it.

- [ ] The work has sufficient tests and/or testing.

- [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

- [x] I have added the appropriate labels to this PR.


Co-authored-by: Jordan Millar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Non-critical improvement or maintenance tasks. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn
Projects
None yet
Milestone
S9 2020-03-26
Development

No branches or pull requests
2 participants
@rhyslbw @Jimbo4350