Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SocketPath and GenesisFile fields to yaml #611

Closed
Jimbo4350 opened this issue Feb 28, 2020 · 1 comment
Closed

Add SocketPath and GenesisFile fields to yaml #611

Jimbo4350 opened this issue Feb 28, 2020 · 1 comment
Labels
maintenance Non-critical improvement or maintenance tasks. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn

Comments

@Jimbo4350
Copy link
Contributor

Adding these two fields to the config yaml file will allow a further reduction in the number of arguments necessary for certain commands in cardano-cli. The socket path can still be specified from the command line and will override the SocketPath field in the config yaml file.

@Jimbo4350 Jimbo4350 added maintenance Non-critical improvement or maintenance tasks. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn labels Feb 28, 2020
@Jimbo4350 Jimbo4350 added this to the S8 2020-03-12 milestone Feb 28, 2020
@cleverca22
Copy link
Contributor

i'm thinking the GenesisFile within the config, should be either an absolute path
or a relative path, relative to where the config is, not the current working dir

iohk-bors bot added a commit that referenced this issue Mar 6, 2020
612: Add `GenesisFile` and `SocketPath` fields to yaml file r=Jimbo4350 a=Jimbo4350

Issue
-----------

- #611 

- This PR refactors the following commands `check-delegation`, `get-tip`, `issue-delegation-certificate`, `issue-genesis-utxo-expenditre`, `issue-utxo-expenditure` and `submit-tx`.

- This PR **results** in breaking changes to upstream dependencies.

Checklist
---------
- [x] This PR contains all the work required to resolve the linked issue.

- [x] The work contained has sufficient documentation to describe what it does and how to do it.

- [ ] The work has sufficient tests and/or testing.

- [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

- [ ] I have added the appropriate labels to this PR.


Co-authored-by: Jordan Millar <[email protected]>
iohk-bors bot added a commit that referenced this issue Mar 19, 2020
648: Add default path for `GenesisFile` and make path relative to configuration yaml file r=Jimbo4350 a=Jimbo4350

Issue
-----------

- #611

- This PR **does not result** in breaking changes to upstream dependencies.

Checklist
---------
- [x] This PR contains all the work required to resolve the linked issue.

- [ ] The work contained has sufficient documentation to describe what it does and how to do it.

- [ ] The work has sufficient tests and/or testing.

- [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

- [x] I have added the appropriate labels to this PR.


Co-authored-by: Jordan Millar <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 3, 2020
750: Make genesis file relative to configuration yaml file fix r=Jimbo4350 a=Jimbo4350

Issue
-----------

- #611 

- This PR **results** in breaking changes to upstream dependencies.

Checklist
---------
- [x] This PR contains all the work required to resolve the linked issue.

- [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

- [x] I have added the appropriate labels to this PR.


Co-authored-by: Jordan Millar <[email protected]>
iohk-bors bot added a commit that referenced this issue Apr 6, 2020
750: Make genesis file relative to configuration yaml file fix r=Jimbo4350 a=Jimbo4350

Issue
-----------

- #611 

- This PR **results** in breaking changes to upstream dependencies.

Checklist
---------
- [x] This PR contains all the work required to resolve the linked issue.

- [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

- [x] I have added the appropriate labels to this PR.


Co-authored-by: Jordan Millar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Non-critical improvement or maintenance tasks. priority medium issues/PRs that SHOULD be addressed. This should be done for the release, but acceptable if it doesn
Projects
None yet
Development

No branches or pull requests

2 participants