Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename committeeQuorum to committeeThreshold #4053

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 6, 2024

Description

Resolves #4018

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/mislabeling branch 2 times, most recently from 131887d to a216cff Compare February 6, 2024 13:44
@aniketd aniketd requested review from lehins and Soupstraw February 6, 2024 13:45
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@aniketd aniketd self-assigned this Feb 7, 2024
@aniketd aniketd force-pushed the aniketd/mislabeling branch from a216cff to a1f6961 Compare February 7, 2024 10:47
@aniketd aniketd enabled auto-merge (squash) February 7, 2024 10:47
@aniketd aniketd force-pushed the aniketd/mislabeling branch from a1f6961 to 836da64 Compare February 7, 2024 11:07
@aniketd aniketd merged commit 849a077 into master Feb 7, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conway mislabeling of Constitutional Committee Parameter
2 participants