Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conway mislabeling of Constitutional Committee Parameter #4018

Closed
intertreeJK opened this issue Jan 28, 2024 · 7 comments · Fixed by #4053
Closed

Conway mislabeling of Constitutional Committee Parameter #4018

intertreeJK opened this issue Jan 28, 2024 · 7 comments · Fixed by #4053
Assignees
Labels
bug Something isn't working conway

Comments

@intertreeJK
Copy link

intertreeJK commented Jan 28, 2024

Tested on current Sancho Testnet

$ cardano-node --version
cardano-node 8.7.3 - linux-x86_64 - ghc-8.10
git rev a4a8119b59b1fbb9a69c79e1e6900e91292161e7

Following Mike Hornan, Nicolas Cerny, and I's recent running of a series of Test Suites to determine what Ratification outcomes would occur across various combinations of Yes/No Votes from the Constitutional Committee's voting on a Proposal. It was discovered that the, so named, 'Quorum' Parameter of the Constitutional Committee is in fact acting with the behaviour of a Threshold Parameter.

It is therefore highly suggested that the official On-Chain naming of the CC Quorum Parameter be changed to reflect its core function. Which is that of a Threshold.

More information about the testing patterns that were run on Sancho Testnet are available at Mike Hornan's Governance GitHub Repository: https://github.com/Hornan7/Testnet_Scenarios

NB: The definition of Quorum is as follows -

"The minimum number of members of an assembly or society that must be present at any of its meetings to make the proceedings of that meeting valid."

It is most certainly not supposed to be the actual target of the required amount of Yes Votes for something to Pass.

It is only supposed to be the amount of people required to actually show up to vote on something before that vote can be considered valid.

As it stands, the Quorum Parameter is currently set up to be an actual target for the amount of Yes Votes required to deem an Action to be Constitutional.

i.e. It may not be working as intended.

If it is...

Then that Parameter needs to be renamed to be Threshold. To avoid any user confusion being created such as the confusion Mike and I had during our predictions of the Voting Outcomes in the Testing Repository linked to above.

It also needs to be made clear in any documentation that the now renamed CC Member 'Threshold' Parameter setting takes precedence over all other Governance Action Threshold Parameter Settings, in the DRep sphere, when it comes to the Constitutional Committee's Voting Process as to the Constitutionality of a Proposal. As was shown during our testing.

I hope this request is acceptable.

Thank you kindly 🙏🏻

@intertreeJK intertreeJK changed the title Conway mislabbeling of Constitutional Committee Parameter Conway mislabeling of Constitutional Committee Parameter Jan 28, 2024
@Hornan7
Copy link

Hornan7 commented Jan 28, 2024

I second Johnny's comments. As you will see in the results of our tests, for a "Quorum" of 3/9:
3 Yes votes and 6 No votes still allows the ratification of governance actions.

Also, 2 Yes votes and 1 No vote does not allow the ratification of governance action.

This does not reflect with the definition of the word "Quorum", and as mentioned by Johnny, I myself have been caught up in unnecessary debate on this subject.

"Threshold" would in my opinion be a much better choice and would avoid many confusing situations such as the one we regularly experience.

Thank you,
--Mike Hornan

@WhatisRT
Copy link
Contributor

Yes, this is indeed supposed to be called a threshold. It used to be a quorum (in name and function) a long time ago in the CIP, but it's been renamed for a while, see the table in the CIP:

2. New constitutional committee and/or threshold and/or terms | Changes to the members of the constitutional committee and/or to its signature threshold and/or terms

Can you point out where the name "quorum" is still used?

@intertreeJK
Copy link
Author

Yes: https://book.world.dev.cardano.org/environments/mainnet/conway-genesis.json

See parameter name in conway-genesis.json for Mainnet for Constitutional Committee.

@lehins
Copy link
Collaborator

lehins commented Jan 29, 2024

Yeah, this never got renamed in the actual implementation.

@intertreeJK Thank you for reporting this, we'll get it renamed.

@lehins lehins added the conway label Jan 29, 2024
@lehins lehins added the bug Something isn't working label Jan 29, 2024
@intertreeJK
Copy link
Author

Splendid!

Much appreciated 🙏🏻

@Hornan7
Copy link

Hornan7 commented Jan 30, 2024

Can you point out where the name "quorum" is still used?

The CC "Quorum" is also mentionned here
And also here, and here

That should be it. 😃👍

@WhatisRT
Copy link
Contributor

I have an open PR to the CIP that fixes this (and lots of other things): cardano-foundation/CIPs#622 I don't want to change it in the changelog though, since that documents historical changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conway
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants