Move "conway governance hash" commands to "hash"

[smelc]

Changelog

- description: |
    Move "conway governance hash" commands to "hash". Users should adapt their calls as follows:
    
    `cardano-cli conway governance hash anchor-data ...` becomes `cardano-cli hash anchor-data ...`
    `cardano-cli conway governance hash script ...` becomes `cardano-cli hash script ...`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #782

[carbolymer]

Makes sense to me. I'm wondering if it would be a good idea to move other hashing commands into this subcommand (e.g. key hash).

[Jimbo4350]

So the hint that hashing is not era based is in the type signature of hashAnchorData:

hashAnchorData :: forall c. Crypto c => AnchorData -> SafeHash c AnchorData

Same for hashKey etc...

And then if you take a look at ledger there is only one instance of Crypto:

instance Crypto StandardCrypto where
  type DSIGN StandardCrypto = Ed25519DSIGN
  type KES StandardCrypto = Sum6KES Ed25519DSIGN Blake2b_256
  type VRF StandardCrypto = PraosVRF
  type HASH StandardCrypto = Blake2b_256
  type ADDRHASH StandardCrypto = Blake2b_224

So what we really want is a top level command that can hash all the hashable things. Or at least not give the impression that hashing depends on the era.

[smelc]

So what we really want is a top level command that can hash all the hashable things. Or at least not to give the impression that hashing depends on the era.

cc @CarlosLopezDeLara since the current design is your ask from #782

I can make hash a top-level command if you approve that like @Jimbo4350 does

[CarlosLopezDeLara]

@smelc I like the idea! sounds great.

[smelc]

@Jimbo4350> Made the command top-level and removed the era.

I will consider in a follow-up PR if other hashing commands can be moved there too (hashing keys).

[Jimbo4350]

LGTM! However I would be wary of breaking the existing hashing functionality. Talk to @CarlosLopezDeLara about this as it may be an annoying for users who have existing scripts etc.

[Jimbo4350]

Unnecessary newline

[smelc]

Done 👍

[Jimbo4350]

I'm not sure I would break this immediately. Better to deprecate it first.

[smelc]

No need to go through a deprecation period, as per @CarlosLopezDeLara's comment below 👇

[Jimbo4350]

Unnecessary newline.

[smelc]

Done 👍

[CarlosLopezDeLara]

LGTM! However I would be wary of breaking the existing hashing functionality. Talk to @CarlosLopezDeLara about this as it may be an annoying for users who have existing scripts etc.

I think we can afford the breaking change here since 9.0 is still in the makings and 8.12 will not cross the hardfork. I'll update docs after this is on a cardano-cli release.

[gitmachtl]

@smelc there are a lot of leftovers in the help texts like:

...
  --anchor-data-hash HASH  Proposal anchor data hash (obtain it with
                           "cardano-cli conway governance hash anchor-data ...")
  --constitution-url TEXT  Constitution URL.
  --constitution-hash HASH Hash of the constitution data (obtain it with
                           "cardano-cli conway governance hash anchor-data
                           ...").
...

pointing to the old location of the hash function conway governance hash

[smelc]

@gitmachtl> yes, it's being fixed by #821. I think that's because I I lost some of my changes while polishing the PR ☹️