Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move conway governance hash to conway hash #782

Closed
CarlosLopezDeLara opened this issue Jun 6, 2024 · 2 comments · Fixed by #787
Closed

Move conway governance hash to conway hash #782

CarlosLopezDeLara opened this issue Jun 6, 2024 · 2 comments · Fixed by #787
Assignees

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Jun 6, 2024

The hash command needs to be moved one level up in the tree, so that it is not inside governance, but instead just in the top level.

@smelc smelc self-assigned this Jun 6, 2024
@smelc
Copy link
Contributor

smelc commented Jun 10, 2024

@CarlosLopezDeLara> what about conway governance hash script then? If we move hash anchor-data out of governance, conway governance hash script will be alone in its category. See here:

https://github.com/IntersectMBO/cardano-cli/blob/fed71b38b5935a0a0e4420aaaab7afa503a25a49/cardano-cli/test/cardano-cli-golden/files/golden/help/conway_governance_hash.cli

@CarlosLopezDeLara
Copy link
Contributor Author

@smelc my bad, I should have written "move 'governance hash' one level up. This is, it can be a more general purpose command rather than specific to governance.

So the end goal is

cardano-cli conway hash (anchor-data | script)
instead of

cardano-cli conway governance hash (anchor-data | script)
Im updating the description

@CarlosLopezDeLara CarlosLopezDeLara changed the title Move conway governance hash anchor-data to conway hash data Move conway governance hash to conway hash Jun 10, 2024
@smelc smelc closed this as completed in #787 Jul 2, 2024
@CarlosLopezDeLara CarlosLopezDeLara added this to the SanchoNet Phase 6 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants