Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cardano-api-8.39.0.0 #616

Closed
wants to merge 1 commit into from

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 21, 2024

Changelog

- description: |
    Update [cardano-api-8.39.0.0](https://github.com/IntersectMBO/cardano-api/blob/main/cardano-api/CHANGELOG.md#83900)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR contains indices bump and redundant imports removal, because of how cardano-api exports things now.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer requested a review from smelc February 21, 2024 15:52
@carbolymer carbolymer marked this pull request as ready for review February 21, 2024 15:58
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-cardano-api branch 2 times, most recently from bb49f00 to 295250b Compare February 21, 2024 17:09
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-cardano-api branch from 295250b to 0d66e39 Compare February 22, 2024 09:37
@carbolymer
Copy link
Contributor Author

carbolymer commented Feb 22, 2024

Hydra windows build is failing because of haskell.nix + blst on windows issues: https://input-output-rnd.slack.com/archives/CG1FBSDMM/p1708462370264619

@palas
Copy link
Contributor

palas commented Feb 23, 2024

Sorry, it seems I did the same exact thing you did in #558 (really wanted to get it merged). I misunderstood something and it didn't occur to me to check whether the imports had been fixed in another PR until after doing it myself 🤦.
Anyway, the way you fixed cardano-cli/src/Cardano/CLI/Pretty.hs is much nicer, I didn't know you could do that.

@carbolymer
Copy link
Contributor Author

carbolymer commented Feb 23, 2024

@palas no worries, thanks for doing that! I've just updated the description of #558.

@carbolymer
Copy link
Contributor Author

Superceded by #558

@carbolymer carbolymer closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants