-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct imports from Cardano.Ledger
#558
Conversation
Cardano.Ledger
Cardano.Ledger
Cardano.Ledger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good however you should ask the team if they prefer Ledger
or L
as the qualified import. We should pick one and stick to it.
cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Actions.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we switch to using one qualified import alias, either L
or Ledger
?
I'd pick L
, seems pretty obvious to me.
22b2463
to
47eaafa
Compare
I've changed it everywhere in: 47eaafa Is that something we want to do? |
b2bdfe1
to
9c4ea75
Compare
In favor of |
cabal.project
Outdated
source-repository-package | ||
type: git | ||
location: https://github.com/IntersectMBO/cardano-api.git | ||
tag: f59090668707b8960a057435a507924ae18be16e | ||
subdir: cardano-api | ||
--sha256: sha256-TJeLlUmZhlckBqQNQVSyFySM66bWa9ggIIOtnNBi0Hs= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since - generally speaking - we don't allow SRPs on main
, you'll need to wait for cardano-api
to be released and updated to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A net improvement, thank you 🙏
I'm approving, but you'll need to wait for a release and update of cardano-api
to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You can squash the commits. Also we can't merge yet until we have another release of cardano-api
.
e29b800
to
d77d91c
Compare
d77d91c
to
ac64002
Compare
Changelog
Context
Issue
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist