Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changelog for PR #610 #612

Closed

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 20, 2024

Changelog

- description: |
    Add missing changelog for PR #610
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
   - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Seems that #610 got in between release PR and tagged merge commit from which we made a release.

screenshot-20240220_151844

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/chore/add-missing-changelog-entry-for-pr610 branch from f848a27 to da770aa Compare February 20, 2024 14:17
@carbolymer carbolymer force-pushed the mgalazyn/chore/add-missing-changelog-entry-for-pr610 branch from da770aa to fafb8f2 Compare February 20, 2024 14:17
@carbolymer carbolymer enabled auto-merge February 20, 2024 14:18
@carbolymer
Copy link
Contributor Author

this is incorrect, I got played by GH linearizing non-linear history, ignore this PR

@carbolymer carbolymer closed this Feb 20, 2024
auto-merge was automatically disabled February 20, 2024 14:21

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant