Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git revision reported by --version on nix build #610

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Feb 13, 2024

Changelog

- description: |
    Fixed git revision showed by --version flag when built using nix
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Addresses this issue: https://github.com/IntersectMBO/cardano-cli/tree/bug-all-zeros-git-revision

How to trust this PR

It can be tested with and without the __GIT_REV__ compiler flag and see that it works either way.

The other thing to pay attention to, is that I have only modified the default logic (when both gitRevEmbed and fromGit are empty)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the bug Something isn't working label Feb 13, 2024
@palas palas self-assigned this Feb 13, 2024
@palas palas linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you get someone from devx to also review?

@palas
Copy link
Contributor Author

palas commented Feb 14, 2024

LGTM. Can you get someone from devx to also review?

@disassembler, could you have a look?

@disassembler disassembler added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 7da4f5b Feb 14, 2024
17 checks passed
@disassembler disassembler deleted the bug-all-zeros-git-revision branch February 14, 2024 17:51
carbolymer added a commit that referenced this pull request Feb 20, 2024
carbolymer added a commit that referenced this pull request Feb 20, 2024
carbolymer added a commit that referenced this pull request Feb 20, 2024
@carbolymer carbolymer mentioned this pull request Feb 20, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - all zeros git revision reported by --version
3 participants