Fix git revision reported by --version on nix build #610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Addresses this issue: https://github.com/IntersectMBO/cardano-cli/tree/bug-all-zeros-git-revision
How to trust this PR
It can be tested with and without the
__GIT_REV__
compiler flag and see that it works either way.The other thing to pay attention to, is that I have only modified the default logic (when both
gitRevEmbed
andfromGit
are empty)Checklist