Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script support when making hot key authorisation certificates #476

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Add script support when making hot key authorisation certificates #476

merged 1 commit into from
Mar 15, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Mar 8, 2024 •
edited
Loading

Changelog

- description: |
    Add plutus script support when making hot key authorisation certificates
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

A prerequisite for:

How to trust this PR

Trust no one.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

newhoggy pushed a commit that referenced this pull request Mar 11, 2024
@carbolymer
Merge pull request #476 from input-output-hk/mgalazyn/fix/mgalazyn/fi…
c50683f 
…x/use-only-stake-creds-for-witnesses

Use `selectStakeCredentialWitness` instead of duplicating credential selection
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch 4 times, most recently from a394707 to 12f804a Compare March 11, 2024 21:08
@carbolymer carbolymer mentioned this pull request Mar 13, 2024
Merged
3 tasks
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch from 12f804a to 050f271 Compare March 13, 2024 16:09
@carbolymer carbolymer changed the title Add script support when making hot key authorization certificates Add script support when making hot key authorisation certificates Mar 13, 2024
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch from 050f271 to 0156385 Compare March 14, 2024 15:37
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch from 0156385 to 3d3315a Compare March 14, 2024 17:26
@carbolymer carbolymer marked this pull request as ready for review March 14, 2024 17:27
@carbolymer carbolymer requested review from smelc and palas March 14, 2024 18:52
@carbolymer carbolymer added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 68fab31 Mar 15, 2024
24 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch March 15, 2024 11:58
Jimbo4350
Jimbo4350 reviewed Mar 27, 2024
View reviewed changes
cardano-api/internal/Cardano/Api/Certificate.hs
@@ -408,19 +408,17 @@ makeDrepRegistrationCertificate (DRepRegistrationRequirements conwayOnwards vcre
data CommitteeHotKeyAuthorizationRequirements era where
CommitteeHotKeyAuthorizationRequirements
:: ConwayEraOnwards era
-> Ledger.KeyHash Ledger.ColdCommitteeRole (EraCrypto (ShelleyLedgerEra era))
-> Ledger.KeyHash Ledger.HotCommitteeRole (EraCrypto (ShelleyLedgerEra era))
-> Ledger.Credential Ledger.ColdCommitteeRole (EraCrypto (ShelleyLedgerEra era))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 left review comments

@smelc smelc smelc approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

@disassembler disassembler Awaiting requested review from disassembler

@palas palas Awaiting requested review from palas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carbolymer @smelc @Jimbo4350