Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend committee create-hot-key-authorization-certificate to support scripts #641

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Extend committee create-hot-key-authorization-certificate to support scripts #641

merged 1 commit into from
Mar 15, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Mar 8, 2024 •
edited
Loading

Changelog

- description: |
    Extend committee `create-hot-key-authorization-certificate` to support scripts
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires:

How to trust this PR

Trust no one.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch 4 times, most recently from 5eae87d to 3e0aeb2 Compare March 13, 2024 15:12
@carbolymer carbolymer linked an issue Mar 13, 2024 that may be closed by this pull request
[FR] - Extend committee create-hot-key-authorization-certificate cmd to support scripts #577
Closed
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch from 3e0aeb2 to b19a059 Compare March 13, 2024 15:31
@carbolymer carbolymer mentioned this pull request Mar 13, 2024
Merged
3 tasks
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch 7 times, most recently from 2351265 to 090ac03 Compare March 14, 2024 17:23
@carbolymer carbolymer marked this pull request as ready for review March 14, 2024 17:25
@carbolymer
Copy link
Contributor Author

PR isn't building, because it requires changes in API from: IntersectMBO/cardano-api#476

@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch from 1a8995b to e23603a Compare March 15, 2024 10:39
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch 3 times, most recently from 36bb8fc to 4d95b3e Compare March 15, 2024 15:57
@carbolymer carbolymer force-pushed the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch from 4d95b3e to 849ba65 Compare March 15, 2024 15:57
@carbolymer carbolymer enabled auto-merge March 15, 2024 15:57
@carbolymer carbolymer added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit b10d80d Mar 15, 2024
17 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/script-support-in-create-hot-key-auth-cert branch March 15, 2024 18:10
Jimbo4350
Jimbo4350 reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however I don't buy into MonadIOTransError at the moment.

cardano-cli/src/Cardano/CLI/Read.hs
-> ExceptT (FileError ScriptDecodeError) IO
ScriptInAnyLang
readFileScriptInAnyLang
:: MonadIOTransError (FileError ScriptDecodeError) t m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constraint is overkill. We only call this in the context of ExceptT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosLopezDeLara CarlosLopezDeLara CarlosLopezDeLara left review comments

@Jimbo4350 Jimbo4350 Jimbo4350 left review comments

@smelc smelc smelc approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

@palas palas Awaiting requested review from palas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Extend committee create-hot-key-authorization-certificate cmd to support scripts
4 participants
@carbolymer @smelc @Jimbo4350 @CarlosLopezDeLara