Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livox driver #8

Open
wants to merge 2 commits into
base: humble
Choose a base branch
from

Conversation

mspringer1
Copy link

@mspringer1 mspringer1 commented Jul 8, 2024

Changes

  • add second lidar launch argument for Livox MID-360
  • changed to OpaqueFunction to allow for conditional launch so users don't need to install all sensor drivers when only one is used

To-Do

Info

  • The package livox_ros_driver2 is already installed on the Go2 by default and does not require a seperate installation

@Juancams
Copy link
Member

Hello @mspringer1

Thank you very much for your contribution, the truth is that I did not know that you could do that with launchers, it is a very useful tool.

Regarding the Livox lidar, we don't have it here, so I'm going to trust that everything is ok (I've launched it and nothing dies at least hahaha).

I am going to leave the pull request without accepting for now, since in a few days we are going to update the urdf with the tf for the realsense and the hesai lidar. When we do it, please update the urdf with the tf to the lidar and we will merge.

Thank you very much again for your contribution.

Greetings.

@mspringer1
Copy link
Author

Hey @Juancams

I just added the livox mid 360 to the urdf.

But with all the different sensor configurations, a logic is needed to only conditionally add a sensor to the urdf based on the launch arguments. Will this also be integrated with the hesai and realsense PR?

@mspringer1 mspringer1 marked this pull request as ready for review July 12, 2024 08:47
@Juancams
Copy link
Member

Of course, the solution we propose is very optimal for choosing which configuration to use. In a few weeks we will integrate it into the main branch.

Thank you so much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants