Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GL-support] Dynamically switching b/w CPU & GPU processing #2989

Conversation

Arun-Prasad-V
Copy link
Contributor

@Arun-Prasad-V Arun-Prasad-V commented Feb 1, 2024

Tracked by LRS-1001

@Arun-Prasad-V Arun-Prasad-V marked this pull request as ready for review February 5, 2024 04:59
@Arun-Prasad-V
Copy link
Contributor Author

I still need to update the readme for this change.

@SamerKhshiboun
Copy link
Collaborator

@Arun-Prasad-V, I understand the flow and the mechanism behind this PR. My question is, couldn't we use this function BaseRealSenseNode::updateSensors() somehow with some parameters, in order to reduce code duplications?
I see that StartVideoSensors and StopVideoSensors and also some other parts of the PR are common with BaseRealSenseNode::updateSensors().
It could make the updateSensors method longer, and we can split it to multiple functions if needed, but again, my idea is to reuse the same code as much as possible, if that is possible :)

@Arun-Prasad-V
Copy link
Contributor Author

@Arun-Prasad-V, I understand the flow and the mechanism behind this PR. My question is, couldn't we use this function BaseRealSenseNode::updateSensors() somehow with some parameters, in order to reduce code duplications? I see that StartVideoSensors and StopVideoSensors and also some other parts of the PR are common with BaseRealSenseNode::updateSensors(). It could make the updateSensors method longer, and we can split it to multiple functions if needed, but again, my idea is to reuse the same code as much as possible, if that is possible :)

Sure, @SamerKhshiboun. Makes sense. will update it.

Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamerKhshiboun SamerKhshiboun merged commit c76358c into IntelRealSense:ros2-development Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants