Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for IMU in l500 #3763

Merged
merged 4 commits into from
Apr 18, 2019
Merged

Conversation

aangerma
Copy link
Contributor

@aangerma aangerma commented Apr 15, 2019

Enable Gyro and Accelerator streams in l500 (on windows and linux)
Tracked On: RS5-3964

@ev-mp ev-mp changed the title Added support on IMU in l500 Added support for IMU in l500 Apr 15, 2019
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline

LOG_WARNING("try_fetch_usb_device(...) failed.");

auto info = std::make_shared<l500_info>(ctx, group, hwm);

#if defined( RS2_USE_WMF_BACKEND) || defined(RS2_USE_V4L2_BACKEND)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires a comment

src/types.h Outdated
@@ -69,6 +69,8 @@ namespace librealsense
{
#define UNKNOWN_VALUE "UNKNOWN"

static const float TIMESTAMP_USEC_TO_MSEC = 0.001;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls move to the respected cpp.

}
}

rs2_time_t iio_hid_timestamp_reader::get_frame_timestamp(const request_mapping& mode, const platform::frame_object& fo)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function has recently been updated in #3726
Please review and merge the changes manually

src/types.h Outdated
#define UNKNOWN_VALUE "UNKNOWN"

static const float TIMESTAMP_USEC_TO_MSEC = 0.001;
static const float TIMESTAMP_USEC_TO_MSEC = 0.001f;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified this one in #3773
Change it manually from float to double for consistency

aangerma and others added 3 commits April 16, 2019 18:40
# Conflicts:
#	src/ds5/ds5-timestamp.cpp
#	src/l500/l500-factory.cpp
#	src/l500/l500-factory.h
@aangerma aangerma force-pushed the development branch 3 times, most recently from a348faf to 1e05150 Compare April 17, 2019 06:56
@ev-mp ev-mp merged commit bd4ea5a into IntelRealSense:development Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants