Adopt dpnp interface to asynchronous dpctl execution (Part #1) #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
…on different SYCL queues
antonwolfy
force-pushed
the
adopt-to-asynchronous-dpctl-execution
branch
from
b106919
to
fcc66b0
Compare
antonwolfy
changed the title
npolina4
reviewed
Jul 1, 2024
vtavana
approved these changes
Jul 2, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 2, 2024
* Update manipulation functions * Update functions from the array creation container * Update dpnp array methods * Implement backward compatible solution * dpnp.meshgrid has to follow CFD and prohibit input arrays allocating on different SYCL queues * updated linspace, logspace and geomspace functions * Updated elementwise functions and astype * Updated counting and histogram functions * Switched back to use dppy/label/dev for coverage GH action * Removed dpnp_container.linspace since unused * Return dpnp ndarray for linspace, logspace and geomspace internal functions 1a4f8a4
This was referenced Jul 7, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were the changes in dpctl interface to make it asynchronous. It caused a number of dpnp tests failing.
On the first stage it is proposed to update dpnp and to adopt with that dpctl changes, but to avoid implementing any change in dpnp interface. There will be no asynchronous handling introduce in dpnp by that stage.
Even with the first stage there are a lot of the changes assumed, because dpnp has to reconsider usage of dpctl interface.
Thus the adaptation will be implemented through several independent PRs separated by dpnp functional blocks.
That PR propose to update all dpnp functions from array creation, elementwise, manipulation, counting and histogram functional blocks.
Even that PR is enough to stabilize the public CI and to have GitHub actions back to green status. It should be helpful and to unblock other PRs which are under review now.
The work on remaining dpnp functions will be continued by further PRs.