Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in responses for DescriptorsCommand #112

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Fix bug in responses for DescriptorsCommand #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DescriptorsCommand.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Json::Value AddDescriptorSet::construct_responses(
};

if (resp["status"] != RSCommand::Success) {
error(resp);
return error(resp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah this one. I had caught it and forgotten to file a bug request last week. I think there was another spot where there was no return.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find it anymore. But just scan through one more time. Wherever check_responses is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably remember this on the remove_api_layer PR, where this was a bug too but I already fixed.

}

int dimensions = cmd["dimensions"].asInt();
Expand Down