Fix bug in responses for DescriptorsCommand #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishakha041
reviewed
Jul 1, 2019
| @@ -163,7 +163,7 @@ Json::Value AddDescriptorSet::construct_responses( | |||
| }; | |||
|
|
|||
| if (resp["status"] != RSCommand::Success) { | |||
| error(resp); | |||
| return error(resp); | |||
There was a problem hiding this comment.
Aah this one. I had caught it and forgotten to file a bug request last week. I think there was another spot where there was no return.
There was a problem hiding this comment.
Can't find it anymore. But just scan through one more time. Wherever check_responses is used.
There was a problem hiding this comment.
You probably remember this on the remove_api_layer PR, where this was a bug too but I already fixed.
vishakha041
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.