Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow: Fix coverage report updates #213

Closed
cwlacewe opened this issue Sep 10, 2024 · 1 comment · Fixed by #217
Closed

Workflow: Fix coverage report updates #213

cwlacewe opened this issue Sep 10, 2024 · 1 comment · Fixed by #217
Assignees
@cwlacewe
Labels
Bug Indicates unexpected or undesired behaviors Workflow Improvements specific to development workflow (i.e. CI changes, unit testing, etc.)
Milestone
v2.10.0 Tasks

Comments

@cwlacewe
Copy link
Contributor

Describe the bug
Currently, the updated coverage reports aren't being pushed if the coverage threshold is not satisfied (Results job fails) even if manually approved. This is shown in PR #209 which will affect coverage comparisons for upcoming PRs.

High chances of new PRs failing because comparing to old coverage values/reports.

Expected behavior
Even if comparison is below threshold, update coverage reports/values for current PR. This will involve removing success check for Update job because currently the job is completely skipped if this occurs and doesn't update anything.

Screenshots
image
@cwlacewe cwlacewe added Bug Indicates unexpected or undesired behaviors Workflow Improvements specific to development workflow (i.e. CI changes, unit testing, etc.) labels Sep 10, 2024
@cwlacewe cwlacewe added this to the v2.10.0 Tasks milestone Sep 10, 2024
@cwlacewe cwlacewe self-assigned this Sep 10, 2024
@cwlacewe cwlacewe mentioned this issue Sep 10, 2024
Merged
@cwlacewe cwlacewe linked a pull request Sep 10, 2024 that will close this issue
Fix #213: Report coverage values on manual approvals #216
Closed
This was referenced Sep 10, 2024
Closed
Merged
@cwlacewe cwlacewe removed a link to a pull request Sep 10, 2024
Fix #213: Report coverage values on manual approvals #216
Closed
@cwlacewe cwlacewe linked a pull request Sep 10, 2024 that will close this issue
Fix #213: Report coverage values on manual approvals #217
Merged
@cwlacewe cwlacewe added the In-Progress Tags issues that are actively being worked on. label Sep 10, 2024
cwlacewe added a commit that referenced this issue Sep 11, 2024
@cwlacewe @sys-vdms
Fix #213: Report coverage values on manual approvals (#217)
a1bacf7 
* Run Update job even if comparison fails in order to update coverage reports (accounts for manual approvals)

* Automated updates: Format and/or coverage

* Modify to always run update job

---------

Co-authored-by: sys_vdms <[email protected]>
@cwlacewe cwlacewe removed the In-Progress Tags issues that are actively being worked on. label Sep 11, 2024
@cwlacewe
Copy link
Contributor Author

Fixed with #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwlacewe cwlacewe

Labels
Bug Indicates unexpected or undesired behaviors Workflow Improvements specific to development workflow (i.e. CI changes, unit testing, etc.)
Projects
None yet
Milestone
v2.10.0 Tasks
Development

Successfully merging a pull request may close this issue.

Fix #213: Report coverage values on manual approvals IntelLabs/vdms
1 participant
@cwlacewe