Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #66

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Release 3.0.0 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2ae37a
Update ffi gem and add some exports to the setup script to ensure tha…
mediocretes Aug 22, 2019
8ffd396
Release v3.0.0
mediocretes Aug 22, 2019
657feb9
reset failure counter when test_connection succeeds
mediocretes Aug 26, 2019
a677daa
add some extra logging code around errors in test_connection. this i…
mediocretes Aug 27, 2019
51b6e06
only log exceptions in test_connection if @logger is present
mediocretes Aug 27, 2019
bd443c0
back out additional logging in test_connection
mediocretes Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### 3.0.0 [August 23, 2019]
* Update ffi gem and setup script

### 3.0.0.alpha [August 22, 2019]
* Drop support for outdated versions of Ruby
* Explicitly add support for new versions of Ruby
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ source "https://rubygems.org"
gemspec

# fixes 2.3.0 ffi bundle error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could deprecate comments. This seems like it is nearing its sell-by date.

gem 'ffi', '~> 1.0.11'
gem 'ffi', '~> 1.11.0'
3 changes: 2 additions & 1 deletion lib/instrumental/agent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,9 @@ def wait_exceptions
def test_connection
begin
@socket.read_nonblock(1)
@failures = 0
rescue *wait_exceptions
# noop
# no-op
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/instrumental/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Instrumental
VERSION = "3.0.0.alpha"
VERSION = "3.0.0"
end
5 changes: 5 additions & 0 deletions script/setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ rbenv which ruby >/dev/null 2>&1 || (brew upgrade ruby-build || true; rbenv inst
# Setup rbenv so we can switch rubies below
eval "$(rbenv init - --no-rehash)"

# make sure FFI is fresh and appropriate flags are set to build native extensions
brew reinstall libffi
export LDFLAGS="-L/usr/local/opt/libffi/lib"
export PKG_CONFIG_PATH="/usr/local/opt/libffi/lib/pkgconfig"

for ruby_version in `ruby -ryaml -e 'puts YAML.load(File.read(".travis.yml"))["rvm"].join(" ")'`; do
rbenv versions --bare | grep "^${ruby_version}$" || rbenv install $ruby_version
rbenv shell $ruby_version
Expand Down