Release 3.0.0 #66
Release 3.0.0 #66
Conversation
…t ffi native extensions can be installed correctly
|
I think probably https://github.com/Instrumental/instrumental_agent-ruby/blob/master/lib/instrumental/agent.rb#L350-L356 needs to set failures to 0 if we have success in the read block, unless you intended the fix to be count failures since agent start? |
|
Totally reasonable. As it is now, it will count up until something forces run_worker_loop to exit, and then it will be reset on the next run, which is fine for the SSL problem we're working on now, but probably not ideal for softer failure modes. |
|
I assume bd443c0 is what we've been using in prod for the last week-ish? |
|
Yes, prod is on 3.0.0.alpha, and looks good so far. |
| @@ -3,4 +3,4 @@ source "https://rubygems.org" | |||
| gemspec | |||
|
|
|||
| # fixes 2.3.0 ffi bundle error | |||
There was a problem hiding this comment.
I wish we could deprecate comments. This seems like it is nearing its sell-by date.
No description provided.