Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: restored old spelling of CLANG_SUPPRESS_Wfloat_equal #4644

Merged
merged 1 commit into from
May 7, 2024

Conversation

seanm
Copy link
Contributor

@seanm seanm commented May 4, 2024

Brought back #define CLANG_SUPPRESS_Wfloat_equal for compatibility with third party code using this as public API.

While here, also prefixed some other defines with ITK to indicate they are from ITK.

@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:Core Issues affecting the Core module labels May 4, 2024
Copy link

@SimonRit SimonRit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thewtex
Copy link
Member

thewtex commented May 6, 2024

Applying clang-format.

@thewtex thewtex added this to the ITK 5.4.0 milestone May 6, 2024
Brought back #define CLANG_SUPPRESS_Wfloat_equal for compatibility with third party code using this as public API.

While here, also prefixed some other defines with ITK to indicate they are from ITK.
@thewtex thewtex merged commit 28de861 into master May 7, 2024
16 checks passed
@thewtex thewtex deleted the clang-suppress-followup branch May 7, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module type:Compiler Compiler support or related warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants