COMP: Suppress some Wformat-nonliteral warnings #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:Compiler
|
This should fix some of these warnings: https://open.cdash.org/viewBuildError.php?type=1&buildid=9572940 |
hjmjohnson
reviewed
Apr 26, 2024
hjmjohnson
force-pushed
the
suppress-warning
branch
2 times, most recently
from
566c36d
to
b3ef504
Compare
github-actions
bot
added
the
type:Infrastructure
hjmjohnson
added
the
action:ApplyClangFormat
hjmjohnson
force-pushed
the
suppress-warning
branch
from
b3ef504
to
5bf59e1
Compare
|
@seanm Ran clang-formatter: ./Utilities/Maintenance/clang-format.bash --clang-format /Users/johnsonhj/Dashboard/src/ITK/cmake-build-release/clang-format-Darwin --tracked |
hjmjohnson
force-pushed
the
suppress-warning
branch
2 times, most recently
from
6e75e99
to
47c9788
Compare
hjmjohnson
approved these changes
Apr 28, 2024
|
Thanks for the touch-ups! |
N-Dekker
reviewed
Apr 29, 2024
Introduced ITK_GCC_PRAGMA_PUSH macro and friends, similiar to existing CLANG_PRAGMA_PUSH and friends, but that applies to both GCC and Clang, which share many warning flags. Added macros to suppess -Wformat-nonliteral warnings. Used them in a few places where the warnings are impossible to fix with ITK's current API. Made -Wfloat-equal apply to GCC now, in addition to Clang. Also added these macros as StatementMacros in the .clang-format file, so that clang-format formats them more nicely. Redid some formatting.
hjmjohnson
force-pushed
the
suppress-warning
branch
from
47c9788
to
001a1a7
Compare
N-Dekker
reviewed
Apr 29, 2024
|
This PR has removed CLANG_SUPPRESS_Wfloat_equal which was used in my code: |
|
Hmm, although it's in a public header, I didn't imaging anyone using it. I'll make a new MR to bring it back. Probably not until later today though, as I'm just recovering from a stomach bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced GCC_PRAGMA_PUSH macro and friends, similiar to existing CLANG_PRAGMA_PUSH and friends, but that applies to both GCC and Clang, which share many warning flags.
Added macros to suppess -Wformat-nonliteral warnings. Used them in a few places where the warnings are impossible to fix with ITK's current API.
Made -Wfloat-equal apply to GCC now, in addition to Clang.
Also added these macros as StatementMacros in the .clang-format file, so that clang-format formats them more nicely. Redid some formatting.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.