Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus indicator and accessibility-compliant contrast for buttons #104

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

PaulGehin
Copy link
Contributor

No description provided.

@garronej
Copy link
Collaborator

garronej commented Jul 3, 2023

Salut Paul,
Merci pour le travail,
Es-ce que tu peut, s'il te plais rebase ta PR pour que le DIFF ne contienne uniquement que les changements.
C'est un prérequis pour travailler en Open source. On ne doit pas avoir de changement d'indentation ou de coding style qui vienent intérférer avec le travail du reviewer.

Tu peut faire une identation dans une autre PR.

D'avance Merci.

Signed-off-by: Paul Géhin <[email protected]>
Signed-off-by: Paul Géhin <[email protected]>
@garronej
Copy link
Collaborator

garronej commented Jul 3, 2023

Thanks a lot, I know it was a bit nit picky, revewing right now

@garronej
Copy link
Collaborator

garronej commented Jul 3, 2023

Very good job, tested and aprooved

@garronej garronej enabled auto-merge July 3, 2023 16:09
@garronej garronej disabled auto-merge July 3, 2023 16:10
@garronej garronej merged commit 0398988 into InseeFrLab:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants