Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button keeps their 'hover' state when clicked. #105

Open
garronej opened this issue Aug 29, 2023 · 0 comments
Open

Button keeps their 'hover' state when clicked. #105

garronej opened this issue Aug 29, 2023 · 0 comments

Comments

@garronej
Copy link
Collaborator

garronej commented Aug 29, 2023

We should keep MUI default behaviour for hover.
This PR was a good temporary patches but it has too many negative side effects.

The real solution is to use a screen scaller that support the use of getBoundingClientRect and other measurement API.
I've started a work toward this: https://github.com/garronej/react-screen-scaler
When we can replace powerhooks's ViewPortProvider with react-screen-scaler all issues related to touch ripple missplacement should go away. It should also solves the misssizing of dropdowns.

garronej added a commit that referenced this issue Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant