This repository has been archived by the owner on May 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: support organization-specific domains for Portal backend and frontend [PORTAL-1067] #165
Draft
burnedikt
wants to merge
9
commits into
develop
Choose a base branch
from
PORTAL-849-domain-name-per-organization
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cbbc714
feat!: support organization-specific domains for Portal backend and f…
burnedikt 8f0c617
test: removed hostname from test, use domain instead
burnedikt 5bbcd46
chore: fixed typo
burnedikt 8c18abb
chore: fixed some undefined variables
burnedikt 94532fa
refactor: use api hostname variable
burnedikt 1e82706
chore: ditch portal_hostname
burnedikt f21a64a
Merge branch 'PORTAL-849-domain-name-per-organization' of github.com:…
burnedikt 11de522
chore: removed accidentally committed test playbook
burnedikt 503909f
chore: removed references to missing portal hostname
burnedikt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,28 +41,12 @@ The password to use to authenticate against the specified docker registry. | |
|
||
### Innoactive Portal | ||
|
||
portal_hostname: | ||
portal_domain: | ||
|
||
**Mandatory** hostname under which the Portal will be available (this needs to be publicly reachable). | ||
|
||
portal_alias_hostnames: [] | ||
|
||
Alternative or legacy hostnames array. Users accessing it will be redirected to portal_hostname. | ||
|
||
admin_hostname: | ||
|
||
**Mandatory** hostname under which the portal control panel will be available. | ||
|
||
admin_alias_hostnames: [] | ||
|
||
Alternative or legacy hostnames array. Users accessing it will be redirected to admin_hostname. | ||
**Mandatory** Domain under which the Portal's Backend, Control Panel and Frontend will be acessible (on a per organization basis à la `<organization>.<portal_domain>`). | ||
|
||
customization_hostname: | ||
|
||
**Mandatory** hostname under shich the customization service will be available. | ||
|
||
customization_alias_hostnames: [] | ||
|
||
Alternative or legacy hostnames array. Users accessing it will be redirected to customization_hostname. | ||
|
||
secret_key: | ||
|
@@ -110,6 +94,10 @@ Optional Google Tag Manager Id. When set, Portal Backend / Control Panel will be | |
|
||
Optional mapping of additional environment variables to be passed on to the Portal Backend (e.g. to unlock hidden features). | ||
|
||
extra_labels: {} | ||
|
||
Optional mapping of additional labels to be passed on to the Portal Backend container. | ||
|
||
extra_volumes: [] | ||
|
||
Optional mapping of additional volumes on the Portal Backend container. | ||
|
@@ -392,10 +380,6 @@ The OAuth2 Client Secret that the Remote (Cloud Rendering) Launcher uses. | |
|
||
Whether or not to setup the Portal frontend for this instance. (Legacy parameter: `setup_discovery_portal: true`) | ||
|
||
portal_hostname: "portal.{{ admin_configuration.primay_hostname }}" | ||
|
||
The hostname under which the Portal frontend should be publicly availabe. This defaults to `portal.<hostname-of-portal-instance>`. | ||
|
||
portal_oauth_client_id: | ||
|
||
Allows to explicitly define the oauth client id to be used by the portal to communicate with the Portal backend. If not defined, | ||
|
@@ -417,6 +401,10 @@ Optional Google Tag Manager Id. When set, Portal Frontend will be setup to load | |
|
||
Optional mapping of additional environment variables to be passed on to the Portal (e.g. to unlock hidden features). | ||
|
||
portal_extra_labels: {} | ||
|
||
Optional mapping of additional labels to be set on the Portal container. | ||
|
||
#### Portal Customization Service | ||
|
||
customization_image_version | ||
|
@@ -445,6 +433,10 @@ an oauth client will automatically be retrieved. | |
|
||
Optional mapping of additional environment variables to be passed on to the Portal Backend (e.g. to unlock hidden features). | ||
|
||
customization_extra_labels: {} | ||
|
||
Optional mapping of additionallabels to be set on the Customization container. | ||
|
||
### Mail Setup | ||
|
||
In order to send mails, SMTP needs to be set up | ||
|
@@ -536,10 +528,9 @@ users too: | |
setup_database: true | ||
setup_control_panel: true | ||
letsencrypt: true | ||
portal_domain: innoactive.io | ||
secret_key: not-secret-at-all-but-okay-for-tests | ||
admin_email: [email protected] | ||
portal_hostname: portal.my.hostname.com | ||
admin_hostname: admin.portal.my.hostname.com | ||
customization_hostname: customization.portal.my.hostname.com | ||
|
||
## Testing | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,7 @@ | |
setup_control_panel: false | ||
letsencrypt: false | ||
secret_key: not-secret-at-all-but-okay-for-tests | ||
admin_hostname: admin.portal.localhost | ||
portal_hostname: portal.localhost | ||
portal_domain: portal.localhost | ||
customization_hostname: customization.portal.localhost | ||
session_management_hostname: session-management.portal.localhost | ||
admin_email: [email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,9 @@ | |
# do not issue certificates from production letsencrypt server | ||
letsencrypt_test: true | ||
secret_key: not-secret-at-all-but-okay-for-tests | ||
admin_hostname: "admin.portal.{{ public_hostname }}" | ||
portal_hostname: "portal.{{ public_hostname }}" | ||
customization_hostname: "customization.portal.{{ public_hostname }}" | ||
session_management_hostname: session-management.portal.{{ public_hostname }}" | ||
portal_domain: "{{ public_hostname }}" | ||
customization_hostname: "customization.{{ public_hostname }}" | ||
session_management_hostname: session-management.{{ public_hostname }}" | ||
admin_email: [email protected] | ||
admin_password: sup3rs3cur3pa55w0rdf0rt3st1ng | ||
session_management_ip_stack_api_token: invalid-token-but-not-empty | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,9 @@ | |
# do not issue certificates from production letsencrypt server | ||
letsencrypt_test: true | ||
secret_key: not-secret-at-all-but-okay-for-tests | ||
admin_hostname: "admin.portal.{{ public_hostname }}" | ||
portal_hostname: "portal.{{ public_hostname }}" | ||
customization_hostname: "customization.portal.{{ public_hostname }}" | ||
session_management_hostname: session-management.portal.{{ public_hostname }}" | ||
portal_domain: "{{ public_hostname }}" | ||
customization_hostname: "customization.{{ public_hostname }}" | ||
session_management_hostname: session-management.{{ public_hostname }}" | ||
admin_email: [email protected] | ||
admin_password: sup3rs3cur3pa55w0rdf0rt3st1ng | ||
session_management_ip_stack_api_token: invalid-token-but-not-empty | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the sender is always
[email protected]
or something like that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the only way without new DKIM verification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either that, or always
[email protected]
which is also weird ...But yeah, definitely affects our terraform module ...
And we don't manage the innoactive.io dns records via terraform, so it's a bit of an issue.