This repository has been archived by the owner on May 5, 2023. It is now read-only.
feat!: support organization-specific domains for Portal backend and frontend [PORTAL-1067] #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rontend - introduced new configuration parameter `portal_domain` - allow specifying extra labels for customization, backend and frontend container BREAKING CHANGE: Removed support for alias hostnames on the backend BREAKING CHANGE: Removed support for alias hostnames on the frontend BREAKING CHANGE: Removed support for alias hostnames on the customization service BREAKING CHANGE: Dropped support for Portal Backend <10.0.0 BREAKING CHANGE: Dropped support for Portal Frontend <3.0.0 BREAKING CHANGE: Dropped support for Portal Customization <3.0.0
burnedikt
changed the title
klyse
reviewed
May 11, 2022
| DJANGO_SECRET_KEY: "{{ admin_configuration.secret_key | mandatory }}" | ||
| FROM_EMAIL: "{{ admin_configuration.from_email | default('admin@' + portal_configuration.hostname, true) }}" | ||
| FROM_EMAIL: "{{ admin_configuration.from_email | default('admin@' + admin_configuration.domain, true) }}" |
There was a problem hiding this comment.
so the sender is always [email protected] or something like that?
There was a problem hiding this comment.
Probably the only way without new DKIM verification.
There was a problem hiding this comment.
either that, or always [email protected] which is also weird ...
But yeah, definitely affects our terraform module ...
And we don't manage the innoactive.io dns records via terraform, so it's a bit of an issue.
Co-authored-by: Klyse <[email protected]>
…Innoactive/ansible-innoactive-portal-role into PORTAL-849-domain-name-per-organization
|
Probably main open topic right now is whether session management supports the new cors origins setting with wildcards. But other than that, the changes here should be more or less complete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
portal_domainBREAKING CHANGE: Removed support for alias hostnames on the backend
BREAKING CHANGE: Removed support for alias hostnames on the frontend
BREAKING CHANGE: Removed support for alias hostnames on the customization service
BREAKING CHANGE: Dropped support for Portal Backend <10.0.0
BREAKING CHANGE: Dropped support for Portal Frontend <3.0.0
BREAKING CHANGE: Dropped support for Portal Customization <3.0.0