feat: External links list files #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: Simplified code
10 tasks
adrien-coye
commented
Sep 27, 2024
3 tasks
Comment on lines
+218
to
+220
| // TODO: Big hack, refactor to allow for non authenticated requests | ||
| guard let someToken = apiFetchers.values.first?.currentToken else { | ||
| fatalError("probably no account availlable") | ||
| fatalError("probably no account available") |
There was a problem hiding this comment.
Do we really need an authenticated ApiFetcher ?
If an ApiFetcher is only needed to init DriveFileManager we can do DriveApiFetcher() without a token
There was a problem hiding this comment.
This code is a leftover of the PoC I did to start this feature.
I'd like to address this in another PR where I correctly handle the offline.
adrien-coye
force-pushed
the
externalLinks-listFiles
branch
from
5884abd
to
fbf4989
Compare
|
PhilippeWeidmann
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI done in this PR
root PR
feature branch
sub PR
Download Files