feat: External links feature branch #1306
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(Endpoint): Finish the external links endpoint implementation
refactor: Simplified code
| } | ||
|
|
||
| let configuration = Configuration(selectAllSupported: false, | ||
| rootTitle: "public share", |
There was a problem hiding this comment.
Either empty or not hardcoded
There was a problem hiding this comment.
yup I had a todo in the old PR
kDrive/UI/Controller/Menu/SharedWithMe/SharedWithMeViewModel.swift
Outdated
Show resolved
Hide resolved
3 tasks
feat: External links list files
feat: External links download files
This was referenced Oct 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Feature PR of the external links
Core tasks so far:
FileListViewControllerMerged PRs:
sub PRs to review:
sub PRs DRAFT:
⚠ Must change deeplink handling backend side when the app is live.