Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ #208

Closed
Infocatcher opened this issue Jan 30, 2016 · 8 comments
Closed

[e10s] Get rid "unsafe CPOW usage", this raise an error in Firefox 47.0a1+ #208

Infocatcher opened this issue Jan 30, 2016 · 8 comments
Labels
bug compatibility

Comments

@Infocatcher
Copy link
Owner

So, we can't use PrivateBrowsingUtils.isWindowPrivate(gBrowser.contentWindowAsCPOW) anymore...
Infocatcher added a commit that referenced this issue Jan 30, 2016
@Infocatcher
Fallback to use tab attribute, if check for content window failed
19d1f63 
(workaround for #208)
@sylveon
Copy link
Contributor

sylveon commented Jan 30, 2016

I also found something else:
12:37:20,473 Only internal code is allowed to set the usePrivateBrowsing attribute bootstrap.js:3557:2
Trigerred when opening a new private tab.

@Infocatcher
Copy link
Owner Author

This warning exists for years... and accessing to usePrivateBrowsing attribute is the only way to make tab private.
Briefly described here: https://addons.mozilla.org/addon/private-tab/#developer-comments

@sylveon
Copy link
Contributor

sylveon commented Jan 30, 2016

Ah. Okay

@Infocatcher Infocatcher mentioned this issue Feb 1, 2016
Closed
@sylveon
Copy link
Contributor

sylveon commented Feb 1, 2016

I got these log entries when disabling and renabling the addon (latest stable), which is totally broken in my Nightly (up-to-date).

12:50:01,432 1454349001432  addons.xpi  WARN    Add-on privateTab@infocatcher is missing bootstrap method shutdown
12:50:01,434 Could not read chrome manifest 'file:///C:/Program%20Files/Nightly/chrome.manifest'.
12:50:01,557 Use of nsIFile in content process is deprecated. Content.js:23:17
12:50:05,059 1454349005058  addons.xpi  WARN    Error loading bootstrap.js for privateTab@infocatcher: SyntaxError: missing ] after element list (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Charles/AppData/Roaming/Mozilla/Firefox/Profiles/Charles/extensions/[email protected]!/bootstrap.js:1569:22) JS Stack trace: @XPIProvider.jsm:4482:1 < [email protected]:4482:7 < [email protected]:4558:9 < [email protected]:4726:13 < [email protected]:7013:9 < [email protected]:1140:9 < [email protected]:1449:5 < initialize/<@extensions.js:104:5 < EventListener.handleEvent*[email protected]:103:3 < EventListener.handleEvent*@extensions.js:78:1

@Infocatcher
Copy link
Owner Author

(latest stable)

With version 0.1.9?
This is due to already fixed #203.

@sylveon
Copy link
Contributor

sylveon commented Feb 1, 2016

Sorry, I completely forgot about Firefox's addon validation times. I thought it already made it.

@Infocatcher Infocatcher mentioned this issue Feb 9, 2016
Closed
Infocatcher added a commit that referenced this issue Feb 9, 2016
@Infocatcher
Workaround for broken documentURIObject from CPOW
0942b29 
(related to #208)
Infocatcher added a commit that referenced this issue Feb 26, 2016
@Infocatcher
Get real tab state using frame script
70ceefe 
(#208)
Infocatcher added a commit that referenced this issue Feb 26, 2016
@Infocatcher
Don't check real state of restored tab in multi-process mode
7c18fb7 
(releted to #208, now we can't get state synchronously)
Infocatcher added a commit that referenced this issue Feb 26, 2016
@Infocatcher
Reduce error messages and tweak debug logs
a399940 
(#162, #208)
@Infocatcher Infocatcher mentioned this issue Mar 1, 2016
Closed
Infocatcher added a commit that referenced this issue Mar 1, 2016
@Infocatcher
Don't call getTabPrivacyContext() for remote tabs
9a5657b 
(to avoid "unsafe CPOW usage" warnings)
(#208)
Infocatcher added a commit that referenced this issue Mar 1, 2016
@Infocatcher
toggleTabPrivate(): check for last private tab in multi-process mode
71cb4f7 
(#162,  #208)
Infocatcher added a commit that referenced this issue Mar 1, 2016
@Infocatcher
toggleTabPrivate(): restore return value in multi-process mode
80e15c8 
Note: may be wrong…
(#162,  #208)
Infocatcher added a commit that referenced this issue Mar 3, 2016
@Infocatcher
Use more documented way to detect remote tabs
8b2c8a5 
(#208)
Infocatcher added a commit that referenced this issue Mar 3, 2016
@Infocatcher
Avoid CPOWs in code to open private tabs from page context menu
2ecb22d 
(#208)
Infocatcher added a commit that referenced this issue Mar 3, 2016
@Infocatcher
Avoid CPOWs in isPrivateContent()
afbe4a8 
(#208)
Infocatcher added a commit that referenced this issue Mar 3, 2016
@Infocatcher
Don't use contentDocumentAsCPOW in workaround for restored tabs
3eb2a7d 
(looks like not needed… and doesn't work anyway)
(#208)
Infocatcher added a commit that referenced this issue Mar 4, 2016
@Infocatcher
Avoid CPOWs in wrapper for browser.loadURIWithFlags() + simplify
6fef2c5 
(#208)
@Infocatcher Infocatcher mentioned this issue Mar 6, 2016
Closed
@Infocatcher Infocatcher mentioned this issue Apr 16, 2016
Closed
5 tasks
@Infocatcher
Copy link
Owner Author

Test version: private_tab-0.1.9.2pre2-fx-sm.xpi (source code)

@sylveon
Copy link
Contributor

sylveon commented Apr 17, 2016

This beta version fixed all the problems that I had with Firefox Nightly.

Infocatcher added a commit that referenced this issue Aug 10, 2016
@Infocatcher
Update changelog:
ec1cb86 
* unsafe CPOW usage (#208)
* updated pt-PT locale (#210)
* e10s: fixed private protocol (#211)
* e10s: tweaks and fixes (#162)
* e10s: single frame script (#213)
* fixed recursion in wrapper for tab.setAttribute("image", …) (#214)
* compatibility with Firefox 51+: broked this.windows getter (#228)
* small internal enhancements and fixes
Infocatcher added a commit that referenced this issue Aug 10, 2016
@Infocatcher
Update changelog:
342bb56 
* unsafe CPOW usage (#208)
* updated pt-PT locale (#210)
* e10s: fixed private protocol (#211)
* e10s: tweaks and fixes (#162)
* e10s: single frame script (#213)
* fixed recursion in wrapper for tab.setAttribute("image", …) (#214)
* compatibility with Firefox 51+: broked this.windows getter (#228)
* small internal enhancements and fixes
Infocatcher added a commit that referenced this issue Aug 10, 2016
@Infocatcher
Update changelog:
84143b2 
* unsafe CPOW usage (#208)
* updated pt-PT locale (#210)
* e10s: fixed private protocol (#211)
* e10s: tweaks and fixes (#162)
* e10s: single frame script (#213)
* fixed recursion in wrapper for tab.setAttribute("image", …) (#214)
* compatibility with Firefox 51+: broked this.windows getter (#228)
* small internal enhancements and fixes
Infocatcher added a commit that referenced this issue Aug 22, 2016
@Infocatcher
Workaround in fix for favicon of image documents
205b098 
(to not break regular favicons)
(#208, #224)
Infocatcher added a commit that referenced this issue Aug 22, 2016
@Infocatcher
Refactor fix for favicon of image documents
207f152 
(#208, #224)
Infocatcher added a commit that referenced this issue Aug 22, 2016
@Infocatcher
Get favicon of image documents in e10s mode
282a726 
(#208, #224)
Infocatcher added a commit that referenced this issue Aug 22, 2016
@Infocatcher
Simplify favicons handling in non-e10s mode
c76db27 
(#208, #224)
Infocatcher added a commit that referenced this issue Aug 24, 2016
@Infocatcher
Limit size of debug logs from setTabAttributeProxy()
2bac717 
(#208, #224)
Infocatcher added a commit that referenced this issue Aug 25, 2016
@Infocatcher
Slightly refactor setTabAttributeProxy() for better readability
fa63385 
(#208, #224)
@Infocatcher Infocatcher mentioned this issue Sep 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Infocatcher @sylveon