Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of tutorials #52

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Add test of tutorials #52

merged 5 commits into from
Jan 11, 2024

Conversation

dalonsoa
Copy link
Collaborator

Run the tutorial files as scripts, raising an error if they do not complete successfully. This DO NOT check if the results are numerically correct, only if the files run without errors.

@dalonsoa dalonsoa linked an issue Jan 10, 2024 that may be closed by this pull request
Copy link
Member

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle this looks good, however the notebooks aren't running to completion on my machine. When I run them as notebooks customise_a_node.py and customise_an_arc.py fail due to problems with paths. When I run them through pytest they all fail with "ModuleNotFoundError: No module named 'wsimod'" which is strange because I've definitely installed wsimod into the venv...

@dalonsoa
Copy link
Collaborator Author

Sorted in 98c4695

# Conflicts:
#	pyproject.toml
#	requirements-dev.txt
@dalonsoa dalonsoa merged commit 491d41e into main Jan 11, 2024
21 checks passed
@dalonsoa dalonsoa deleted the tutorials branch January 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tutorials as tests
2 participants