Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tutorials as tests #36

Closed
dalonsoa opened this issue Nov 4, 2023 · 0 comments · Fixed by #52
Closed

Run tutorials as tests #36

dalonsoa opened this issue Nov 4, 2023 · 0 comments · Fixed by #52
Labels
enhancement New feature or request

Comments

@dalonsoa
Copy link
Collaborator

dalonsoa commented Nov 4, 2023

WSIMOD includes several tutorials that could very well serve as integration tests if run as part of the test suite. Initially the goal would be just to check that they run without errors.

A further refinement that could be implemented would be to save the outputs of running the models in the tests folder as the "truth" and then, when running the tutorials, compare if the actual outputs agree with the expected ones. But that requires a bit more work and will need to be done after #24 since at the moment no output files are produced.

@dalonsoa dalonsoa added the enhancement New feature or request label Nov 4, 2023
@dalonsoa dalonsoa linked a pull request Jan 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant