Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extend ci #76

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Feature/extend ci #76

merged 4 commits into from
Sep 26, 2022

Conversation

davidorme
Copy link
Collaborator

Description

This PR just extends the CI workflow to include Windows (since #69 removed the requirement forfiona) and adds Python 3.10 into the matrix. This is pinned at 3.10.6 because of a mypy issue - but a release of mypy to allow us to unpin to 3.10 is expected soon.

Fixes #75

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov-commenter
Copy link

Codecov Report

Merging #76 (f68413f) into develop (35769a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #76   +/-   ##
========================================
  Coverage    67.50%   67.50%           
========================================
  Files            3        3           
  Lines           80       80           
========================================
  Hits            54       54           
  Misses          26       26           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.github/workflows/ci.yml Show resolved Hide resolved
@davidorme davidorme merged commit e184771 into develop Sep 26, 2022
@davidorme davidorme deleted the feature/extend_ci branch September 26, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI setup to include Windows and wider Python versions.
4 participants