Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch to fix wheel issue #299

Merged
merged 11 commits into from
Sep 26, 2024
Merged

branch to fix wheel issue #299

merged 11 commits into from
Sep 26, 2024

Conversation

barneydobson
Copy link
Collaborator

@barneydobson barneydobson commented Sep 25, 2024

Description

OK there were a few issues - small but took forever to track down. Here is the release action: https://github.com/ImperialCollegeLondon/SWMManywhere/actions/runs/11040266148

  • It didn't like having licenses in the normal way - I had to do them in the hatch way.
  • I removed the bit telling sdist where to look - not sure if it was necessary but the canonical example in black had it like that so I thoguht it might work.. I'm too tired to see if it works without this change.
  • check-wheel-file assumes by default a single toplevel library. the hynek tool which calls that doesn't give an option to customise this - so I've told it to skip-wheel.
  • I tried addingcheck-wheel-file specifying multiple toplevel libraries separately below - which works locally, but not upstream because of the wildcard.. I'm beyond caring now - so if one of you wants to do it tomorrow then great - otherwise I will merge and rerelease on main and we're done!
    - name: Check wheel contents
      run: |
        pip install check-wheel-contents
        check-wheel-contents dist/swmmanywhere-*.whl --toplevel="swmmanywhere","netcomp"
  • The final pypi publish still seems to fail even though the pypi test is fine because the hynek tool has created a swmmanywhere-0.1.2.tar.gz (which already exists and so causes the error despite the release being 0.1.3) - I'm hoping this is something to do with the fact that I'm not releasing from main but instead this branch.

Fixes #290

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@barneydobson barneydobson merged commit f00cb38 into main Sep 26, 2024
32 of 34 checks passed
@barneydobson barneydobson deleted the test_wheel branch September 26, 2024 08:08
@barneydobson
Copy link
Collaborator Author

closed it because that fixed the release - feel free to reopen or start a new issue if you want to address the wheel check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netcomp not working properly
1 participant