netcomp not working properly

[barneydobson]

Assuming have copied config and updated accordingly. @dalonsoa it'd be amazing if you could take a look please.

python -m venv ./sa_env
./sa_env/Scripts/activate.bat
pip install swmmanywhere
python -m swmmanywhere --config_path=minimum_viable_template.yml 

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\bdobson\Downloads\temp\sa_env\Lib\site-packages\swmmanywhere\__main__.py", line 8, in <module>
    from swmmanywhere import swmmanywhere
  File "C:\Users\bdobson\Downloads\temp\sa_env\Lib\site-packages\swmmanywhere\swmmanywhere.py", line 22, in <module>
    from swmmanywhere.metric_utilities import iterate_metrics, validate_metric_list
  File "C:\Users\bdobson\Downloads\temp\sa_env\Lib\site-packages\swmmanywhere\metric_utilities.py", line 21, in <module>
    import netcomp
ModuleNotFoundError: No module named 'netcomp'

[dalonsoa]

It seems that netcomp was included in the source application but not in the wheel, so when installed from PyPI, it is not there. Let's see what I need to do to make that happen. This will require another release, I'm affraid, and mark the previous one as wrong, so no one installs it.

[barneydobson]

OK great thanks - how do I mark as wrong?

[barneydobson]

closed by #293

[cheginit]

@barneydobson make sure to yank the release. Can be done by the manager of the package on https://pypi.org/ which I think is @dalonsoa?

[barneydobson]

I think @dalonsoa did 👍

[barneydobson]

@dalonsoa new bug with the distribution:

Run if [[ "false" != 'true' ]]; then
/tmp/baipp/dist/swmmanywhere-0.1.2-py3-none-any.whl: W009: Wheel contains multiple toplevel library entries:
  netcomp/
  swmmanywhere/
Error: Process completed with exit code 1.

[cheginit]

You need to move the netcomp folder under swmmanywhere as a subpackage.

[dalonsoa]

I've just seen it, but I don't understand why that is a problem. The wheel works and it is not uncommon to distribute multiple packages together. If we move netcomp to within swmmanywhere, we need to change all of import statements for netcomp.

[barneydobson]

looking at examples - could we move both into src?

[dalonsoa]

That's what I was starting to think, to be honest.

[cheginit]

I second the src-layout (I use it for all my projects). You have to make a couple of changes to pyproject.toml for hatchling, pytest, and coverage.

[dalonsoa]

On it...

[barneydobson]

OK still failing: https://github.com/ImperialCollegeLondon/SWMManywhere/actions/runs/11036163538/job/30654221348

I guess we're not fixing this today - but any ideas from @cheginit or @dalonsoa are welcome!

[barneydobson]

( I will first try the suggestion here )

[barneydobson]

(nope didn't help)