-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support For Constant Basis In Splines #1298
Conversation
ce76ca4
to
87f18dd
Compare
Note to self : don't merge this without retargeting it to RB-10.4. |
87f18dd
to
1fc2ed5
Compare
Rebased onto RB-10.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - might be worth addressing that one comment though (I don't think it changes the outcome, but it also doesn't seem to match our intentions as well as it could).
@@ -650,7 +675,7 @@ IECore::DataPtr loadSpline( | |||
size_t n = std::min( positions.size(), values.size() ); | |||
for( size_t i = 0; i < n; ++i ) | |||
{ | |||
if( unduplicateEndPoints && ( i == 0 || i == n - 1 ) ) | |||
if( unduplicateEndPoints && ( i < unduplicateStartPoints || i >= n - unduplicateEndPoints ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can drop the unduplicateEndPoints &&
part?
1fc2ed5
to
bb0adc7
Compare
Addressed comment. |
Adding support for "constant" basis for splines which creates stair step shapes. Turned up a few oddities in the solver and tests, but seems to be working fine now.