Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Constant Basis In Splines #4839

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

danieldresser-ie
Copy link
Contributor

@danieldresser-ie danieldresser-ie commented Sep 14, 2022

Requires ImageEngine/cortex#1298

Exposes Constant basis for splines in Gaffer. Everything appears to match properly with Cortex, after the fix to GafferOSL/Spline.h

Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs an edit to Changes.md though.

We also need to discuss what to do with the Windows CI - do we wait for a package update from Eric, disable Windows CI temporarily, let Windows CI fail temporarily, or #ifdef our way around older Cortex versions?

@johnhaddon
Copy link
Member

Pushed an update which sorts out Changes.md and updates the CI packages to Cortex 10.4.2.1, which should get this building on Windows.

@johnhaddon johnhaddon merged commit 66bcb1e into GafferHQ:1.0_maintenance Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants