Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chip): styling discrepancies #1486

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(chip): styling discrepancies #1486

wants to merge 7 commits into from

Conversation

SisIvanova
Copy link
Contributor

Closes #1458

@SisIvanova SisIvanova requested a review from simeonoff November 18, 2024 13:53
@didimmova
Copy link
Contributor

There are still some misalignments colorwise in the foregrounds in different variants. Please check this out with the design team if possible.

simeonoff
simeonoff reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we shouldn't be modifying the icon sizes in the context of the chip component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@sdimchevski sdimchevski

@didimmova didimmova

Labels
chip themes ❌ status: awaiting-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip discrepancies
4 participants
@SisIvanova @didimmova @simeonoff @sdimchevski