Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip discrepancies #1458

Open
didimmova opened this issue Nov 1, 2024 · 0 comments · May be fixed by #1486
Open

Chip discrepancies #1458

didimmova opened this issue Nov 1, 2024 · 0 comments · May be fixed by #1486
Assignees
Labels
bug Something isn't working chip

Comments

@didimmova
Copy link
Contributor

didimmova commented Nov 1, 2024

Which component(s) are affected?

Chip

Description

  • When the prefix and suffix are not used, they're present in the dom and empty, but expand the chip. When prefix or suffix slot is empty, it should not expand the chip, the chip should be left with just it's paddings.
Screenshot 2024-11-01 at 8 31 18
  • Also the foreground color of the disabled chip should be the same in all variants. In bootstrap theme the foreground is not the 'disabled' one in all variants. These are disabled bootstrap info and success chips
Screenshot 2024-11-04 at 14 59 16 Screenshot 2024-11-04 at 14 58 44
  • The slotted icons in the chip aren't the right size, only the default select and remove icons are right, but if you slot an icon as a prefix/suffix/custom select or remove icon, they're getting the icon sizes, not the ones that a slotted icon in the chip should
Screenshot 2024-11-04 at 14 58 14

Reproduction

Check out the chip story, explore different themes and sizes and compare with UI kits.

Workaround

I have not found a workaround

Is this a regression?

No or unsure. This never worker, or I haven't tried before.

Affected versions

all

Browser/OS/Node environment

all

@didimmova didimmova added bug Something isn't working 🆕 status: new The issue is new and will be reviewed when somebody picks it up. chip labels Nov 1, 2024
@didimmova didimmova changed the title Chip prefix and suffix expand the chip when empty Chip prefix and suffix expand the chip when empty || wrong foreground color on disabled Nov 4, 2024
@didimmova didimmova changed the title Chip prefix and suffix expand the chip when empty || wrong foreground color on disabled Chip discrepancies Nov 4, 2024
@SisIvanova SisIvanova assigned SisIvanova and unassigned simeonoff Nov 15, 2024
@SisIvanova SisIvanova removed the 🆕 status: new The issue is new and will be reviewed when somebody picks it up. label Nov 15, 2024
@SisIvanova SisIvanova linked a pull request Nov 18, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chip
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants