Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes from AngularDocFX_EN #1199

Merged
merged 134 commits into from
May 29, 2019
Merged

Changes from AngularDocFX_EN #1199

merged 134 commits into from
May 29, 2019

Conversation

ESShared
Copy link
Contributor

No description provided.

tachojelev and others added 22 commits April 9, 2019 13:54
@tachojelev
docs(list): update topic with displayDensity
8323b22 
IgniteUI/igniteui-angular#4393
@ViktorSlavov
docs(drop-down): add virtual drop-down topic
a261095
@ViktorSlavov
docs(drop-down): add links to value and index inputs
6f69fd3
@ViktorSlavov
docs(drop-down): fix wording and typos
375cfbe
@tachojelev
docs(button): update topic with displayDensity
678c5e5 
IgniteUI/igniteui-angular#4502
@PavlovVasil
changing the img to be responsive
bf6fad4
@tachojelev
Merge branch 'master' of https://github.com/IgniteUI/igniteui-docfx
bedb1dd
@wnvko
docs(igxOverlay): update Auto startegy
e1f7ede
@ViktorSlavov
docs(drop-down): add drop-down remote scenario
f1e925d
@wnvko
docs(igxOverlay): update wording
6167ac4
Adding changes from build AngularDocFX_EN_2019.4.16.3
9b0b04c
Adding changes from build AngularDocFX_EN_2019.4.16.5
1973d18
Adding changes from build AngularDocFX_EN_2019.4.16.7
e994127
Adding changes from build AngularDocFX_EN_2019.4.16.8
5dccfec
@zdrawku
Update version
7120f8c
@wnvko
docs(igxOverlay): update wording
69ce8c5
@zdrawku
Merge pull request IgniteUI#1200 from IgniteUI/update-docfx-template-…
7d9ced3 
…version-to-2018

Update version
Merge branch 'AngularBuild_EN' of https://github.com/ESShared/ignite-…
20b0fc1 
…ui-docfx into AngularBuild_EN
Adding changes from build AngularDocFX_EN_2019.4.17.2
5c1c34f
@Lipata
feat(grid-row-drag): initial structure IgniteUI#1202
df6ddc9
@ViktorSlavov
docs(drop-down): change code snippet for virtual remote data
8faae87
Adding changes from build AngularDocFX_EN_2019.4.18.5
414c8b5
@hanastasov hanastasov assigned hanastasov and unassigned hanastasov Apr 18, 2019
@zdrawku
Copy link
Contributor

zdrawku commented Apr 18, 2019 •
edited
Loading

@HUSSAR-mtrela and @agoldenbaum we've added some changes to this PR, and a lot more are yet to come, related to issues #1201

My question is, could you show us how (if possible) to create separate PRs with the changes, for better consistency and easing the Verify&Review process? One of the changes will affect more than 300 files, part of the logic that we've added for the Themes in DocFX (all DV topics won't have any theming)

mpavlinov and others added 25 commits May 8, 2019 18:38
@mpavlinov
Adding topic for jp, kr
f6c5399
@mpavlinov
Adding images for jp, kr
1b58a11
@mpavlinov
Merge pull request IgniteUI#1216 from IgniteUI/dkamburov/mrl
f693d1c 
Multi row layout topic
@yoshimis
Updated for IgniteUI#1223.
5e44b18
@yoshimis
Updated for IgniteUI#1203.
74450db
@yoshimis
Updated for IgniteUI#1203.
febcc70
@yoshimis
Updated for IgniteUI#1179 and IgniteUI#1222.
3de04d5
@yoshimis
Updated for IgniteUI#1224.
9dc672b
@hanastasov
just a small code snippet change
8d380b9
@yoshimis
Localized spreadsheet hyperlinks topic.
517b545
@yoshimis
Updated toc.
834a692
@valadzhov
Trying to fix an issue with the TOC.
703a0e0
@valadzhov
More efforts for fixing the TOC.
e963634
@valadzhov
More TOC changes.
fc1baca
@valadzhov
TOC changes.
87bc370
@valadzhov
Adding localization for two strings.
b7e319a
@valadzhov
Removing the localized multi_row_layout.md and placing it in the grid…
1c7cf9c 
…s folder.
@hanastasov @zdrawku
Update en/components/grid/grid.md
03a8e59 
change the frame id

Co-Authored-By: Zdravko Kolev <[email protected]>
@hanastasov @zdrawku
Update en/components/grid/grid.md
54008f7 
Update the correct data-iframe-id

Co-Authored-By: Zdravko Kolev <[email protected]>
@hanastasov
correct the state sample iframe id
9b3f949
@hanastasov
fix iframe for lazyloading
5070018
@zdrawku
Merge pull request IgniteUI#1227 from IgniteUI/add-state-persistence-…
4d8e071 
…topic

Add state persistence topic
Merge branch 'AngularBuild_EN' of https://github.com/ESShared/ignite-…
bd5c799 
…ui-docfx into AngularBuild_EN
@zdrawku
Merge pull request IgniteUI#1230 from IgniteUI/ysugiura/0509
0908840 
Ysugiura/0509
Merge branch 'AngularBuild_EN' of https://github.com/ESShared/ignite-…
d12fd52 
…ui-docfx into AngularBuild_EN
@pamelabrasil
Copy link
Contributor

@zdrawku @HUSSAR-mtrela Some of the changes in this PR revert a couple of changes from these ones: #1126 #1125 #1120.
The changes are not critical and easily could be applied again through the xplat-docfx, but we should consider how we can even the igniteui-docfx and xplat-docfx versions to prevent future issues

All changes should be done in the xplat-docfx repo. Otherwise, all changes in docfx repo will be overwritten every time there is a PR

@pamelabrasil pamelabrasil dismissed HristoP96’s stale review May 29, 2019 15:38

all changes must be done in the xplat repo. otherwise everything will be overwritten through the PRs

@pamelabrasil pamelabrasil self-requested a review May 29, 2019 15:39
@pamelabrasil pamelabrasil merged commit 3df0b17 into IgniteUI:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamelabrasil pamelabrasil pamelabrasil approved these changes

@HristoP96 HristoP96 HristoP96 left review comments

@HUSSAR-mtrela HUSSAR-mtrela Awaiting requested review from HUSSAR-mtrela

@agoldenbaum agoldenbaum Awaiting requested review from agoldenbaum

Assignees

@HristoP96 HristoP96

Labels
status: not-fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.