Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Display Density for the IgxList #4393

Closed
6 tasks done
tachojelev opened this issue Mar 25, 2019 · 1 comment
Closed
6 tasks done

Implement Display Density for the IgxList #4393

tachojelev opened this issue Mar 25, 2019 · 1 comment
Assignees
@simeonoff @tachojelev @gedinakova @desig9stein
Labels
list 🧰 feature-request version: 7.3.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@tachojelev
Copy link
Contributor

tachojelev commented Mar 25, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

We need to have a displayDensity input for the IgxList in order to be able to implement a displayDensity for the Excel Style Filtering dialog, which uses the IgxList (#4300).

Describe the solution you'd like

IgxListComponent or IgxListBase should extend DisplayDensityBase.

Describe alternatives you've considered

N/A

Additional context

The igx-list will have a different css class based on the its displayDensity input value. The list items will be styled accordingly as well.

  • Tests
  • Development
  • README
  • Specification
  • Documentation
  • Samples
@tachojelev tachojelev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 25, 2019
tachojelev added a commit that referenced this issue Mar 25, 2019
@tachojelev
test(list): add displayDensity tests #4393
e4430bf
tachojelev added a commit that referenced this issue Mar 25, 2019
@tachojelev
feat(list): implement display density #4393
b57b377
@tachojelev tachojelev mentioned this issue Mar 26, 2019
Merged
14 tasks
tachojelev added a commit that referenced this issue Apr 8, 2019
@tachojelev
fix(list): rever list-item logic #4393
3252cf0
tachojelev added a commit that referenced this issue Apr 8, 2019
@tachojelev
test(list): update display density tests #4393
06eb65c
tachojelev added a commit that referenced this issue Apr 8, 2019
@tachojelev
feat(list): replace attr with class hostbind #4393
006fa6b
tachojelev added a commit that referenced this issue Apr 8, 2019
@tachojelev
chore(*): remove redundant dependencies #4393
f822935
tachojelev added a commit that referenced this issue Apr 8, 2019
@tachojelev
chore(*): fix list sample #4393
53f36ff
tachojelev added a commit that referenced this issue Apr 8, 2019
@tachojelev
chore(*): make lint happy #4393
929f10c
tachojelev added a commit that referenced this issue Apr 9, 2019
@tachojelev
docs(list): update README and CHANGELOG #4393
70992f4
tachojelev added a commit to IgniteUI/igniteui-docfx that referenced this issue Apr 9, 2019
@tachojelev
docs(list): update topic with displayDensity
8323b22 
IgniteUI/igniteui-angular#4393
@tachojelev tachojelev mentioned this issue Apr 9, 2019
Merged
@tachojelev tachojelev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 9, 2019
tachojelev added a commit that referenced this issue Apr 9, 2019
@tachojelev
chore(*): remove inline style #4393
01c924f
tachojelev added a commit that referenced this issue Apr 9, 2019
@tachojelev
chore(*): add bottom-margin to sample #4393
e58d7c4
tachojelev added a commit to IgniteUI/igniteui-angular-samples that referenced this issue Apr 9, 2019
@tachojelev
samples(list): update sample with displayDensity
36427ee 
IgniteUI/igniteui-angular#4393
@tachojelev tachojelev mentioned this issue Apr 9, 2019
Merged
@rkaraivanov
Copy link
Member

closed via #4401

tachojelev added a commit to IgniteUI/igniteui-docfx that referenced this issue Apr 22, 2019
@tachojelev
fix(docs): add missing word
2d08718 
IgniteUI/igniteui-angular#4393
tachojelev added a commit to IgniteUI/igniteui-angular-samples that referenced this issue May 7, 2019
@tachojelev
chore(*): make lint happy
78147ca 
IgniteUI/igniteui-angular#4393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

@tachojelev tachojelev

@gedinakova gedinakova

@desig9stein desig9stein

Labels
list 🧰 feature-request version: 7.3.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@simeonoff @tachojelev @gedinakova @rkaraivanov @desig9stein