Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migrations for chained members #9858

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Fix migrations for chained members #9858

merged 3 commits into from
Jul 22, 2021

Conversation

jackofdiamond5
Copy link
Member

@jackofdiamond5 jackofdiamond5 commented Jul 14, 2021 •
edited
Loading

Closes #9347

TODO:

  • Extract some of the logic to private methods

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/migrations-members-fixes branch from de0bc58 to ae6e1e5 Compare July 20, 2021 11:29
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/migrations-members-fixes branch from ae6e1e5 to c529cf5 Compare July 20, 2021 12:59
damyanpetev
damyanpetev previously approved these changes Jul 21, 2021
View reviewed changes
@ViktorSlavov ViktorSlavov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 21, 2021
@ViktorSlavov ViktorSlavov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 22, 2021
@Lipata Lipata requested a review from damyanpetev July 22, 2021 07:03
@jackofdiamond5 jackofdiamond5 force-pushed the bpenkov/migrations-members-fixes branch from 016c6aa to 4dcc520 Compare July 22, 2021 08:59
@Lipata Lipata merged commit e32732d into master Jul 22, 2021
@Lipata Lipata deleted the bpenkov/migrations-members-fixes branch July 22, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

Assignees

@ViktorSlavov ViktorSlavov

Labels
migrations version: 12.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrations are failing for certain scenarios
4 participants
@jackofdiamond5 @damyanpetev @Lipata @ViktorSlavov